Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropppping unmaintained code #148

Closed
mosra opened this Issue Jun 4, 2016 · 10 comments

Comments

4 participants
@mosra
Copy link
Owner

commented Jun 4, 2016

Assuming nobody uses the following parts anymore, I propose deprecating and then dropping them:

  • Shapes namespace. Poorly designed, sparsely implemented and of no real use. This would make #5 and also the DebugTools::ShapeRenderer class obsolete. Affects the Bullet and Audio example, which would need to be reworked without these (shouldn't be hard, we could also make use of instancing there) -- deprecated in 8efc6b3
  • Platform::GlutApplication class. Is there any platform that has GLUT but doesn't have SDL2? The class is not receiving any updates anymore and I'm not sure if it even works. -- deprecated in d70f75a
  • ColladaImporter plugin. Depends on outdated Qt4, supports only some features because COLLADA files are impossible to parse and I don't plan to extend it anymore. I propose replacing it with general-purpose importer based on Assimp (#146) -- deprecated in mosra/magnum-plugins@35ee1a2
  • The compatibility branch, along with support for GCC 4.4, 4.5, 4.6 and MSVC 2013.

@mosra mosra added the compatibility label Jun 4, 2016

@mosra mosra self-assigned this Jun 4, 2016

@wivlaro

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2016

@Squareys

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2016

Affects bullet example, which would need to be reworked

And audio example, too ;) But replacing by mesh primitives should be fine there too.

And I believe the "WIP" Octree implementation uses it, but that's my responsibility to deal with.

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Aug 16, 2016

New item added: completely dropping the compatibility branch, along with support for GCC 4.4, 4.5, 4.6 and MSVC 2013. The branch wasn't updated since October last year so I don't expect anyone to still depend on it. For me it's real maintenance nightmare.

The last reason why I wanted to keep it was Windows Phone SDK that still depends on MSVC 2013, but since that platform is also almost dead, the pain-to-portability ratio is too high.

Please raise objections if you have a different opinion.

@manuel-kroeter

This comment has been minimized.

Copy link

commented Aug 24, 2016

We might need some line - sphere/box collision detection for selecting objects but we could also implement it ourselves. As I have seen so far, the shapes are currently implemented for floats only anyway.

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Aug 24, 2016

@ManuelK89 The actual "brain" of the Shapes namespace is in Math::Geometry, where all most of the intersection/distance algorithms are implemented -- e.g. line/sphere intersection is just a call to Math::Geometry::Distance::linePointSquared()

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Oct 8, 2016

The compatibility branch is now removed along with all documentation references to it. If you happen to still find any reference to it, please tell me.

@mosra mosra changed the title Droppping unmaintained code Dropppping unmaintained code Oct 10, 2016

@mosra mosra referenced this issue Jul 25, 2018

Closed

2018.10 release #265

56 of 56 tasks complete

@mosra mosra added this to the 2018.0c milestone Jul 25, 2018

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Aug 24, 2018

GlutApplication is deprecated since d70f75a.

@mosra mosra moved this from TODO to In progress in Project management Aug 30, 2018

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Aug 30, 2018

Shapes namespace and DebugTools::ShapeRenderer is deprecated since 8efc6b3.

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Aug 31, 2018

ColladaImporter is deprecated in mosra/magnum-plugins@35ee1a2, BulletIntegration::convertShape() in mosra/magnum-integration@968fa40. That wraps up the deprecation round for 2018.0c, removal is postponed to at least 6 months later.

@mosra mosra removed this from the 2018.0c milestone Aug 31, 2018

@mosra mosra removed the compatibility label Sep 26, 2018

@mosra mosra added this to the 2019.0b milestone Mar 13, 2019

@mosra

This comment has been minimized.

Copy link
Owner Author

commented Mar 16, 2019

Everything is removed now:

Together with #81 it totalled in around 18k lines removed. Not bad 🔥 🔥 🔥

@mosra mosra closed this Mar 16, 2019

Project management automation moved this from In progress to Done Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.