Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2application window icon update #393

Closed
hsdk123 opened this issue Nov 14, 2019 · 4 comments

Comments

@hsdk123
Copy link

@hsdk123 hsdk123 commented Nov 14, 2019

Window icons tend to be one of those subtle but immediately noticeable finishing touches for an application. The following request is an addition of https://wiki.libsdl.org/SDL_SetWindowIcon to the sdl2application api.

@mosra mosra added this to the 2019.1c milestone Nov 16, 2019
@mosra mosra added this to TODO in Platforms via automation Nov 16, 2019
@mosra

This comment has been minimized.

Copy link
Owner

@mosra mosra commented Nov 16, 2019

Argh, why the SDL APIs have to be so underwhelming. GLFW has an API for setting a sequence of differently sized images, so one can be sure the icon looks great regardless of its size, but SDL accepts only a single image :/

@hsdk123

This comment has been minimized.

Copy link
Author

@hsdk123 hsdk123 commented Nov 17, 2019

Looks like it's time for the mosra to rise up and fill in the blanks!

I wouldn't mind just having one image for a starting implementation though.

@mosra

This comment has been minimized.

Copy link
Owner

@mosra mosra commented Nov 17, 2019

Done with 090c6bb. According to my tests, if you supply a large enough image, it gets scaled down, which is better than a small image getting a blurry upscale, but still. GLFW has it better :)

Let me know if there are any issues with this.

@mosra mosra closed this Nov 17, 2019
Platforms automation moved this from TODO to Done Nov 17, 2019
@hsdk123

This comment has been minimized.

Copy link
Author

@hsdk123 hsdk123 commented Nov 17, 2019

Nice, looks good - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Platforms
  
Done
2 participants
You can’t perform that action at this time.