Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access violation with GlfwApplication and std::getenv #400

Closed
alanjfs opened this issue Nov 20, 2019 · 3 comments

Comments

@alanjfs
Copy link
Contributor

@alanjfs alanjfs commented Nov 20, 2019

I think this will try and compare a string to a nullptr, when the environment isn't there.

if(std::strncmp(std::getenv("XDG_SESSION_TYPE"), waylandString, sizeof(waylandString)) != 0)

image

@mosra mosra added this to the 2019.1c milestone Nov 20, 2019
@mosra mosra added this to TODO in Platforms via automation Nov 20, 2019
@mosra

This comment has been minimized.

Copy link
Owner

@mosra mosra commented Nov 20, 2019

First of all: congrats on issue #400! 🎉

@alanjfs

This comment has been minimized.

Copy link
Contributor Author

@alanjfs alanjfs commented Nov 20, 2019

Woho, my first one at that!

Edit: Forgetting about my previous two submissions. xD

@mosra

This comment has been minimized.

Copy link
Owner

@mosra mosra commented Nov 20, 2019

Fixed by #401 :)

@mosra mosra closed this Nov 20, 2019
Platforms automation moved this from TODO to Done Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Platforms
  
Done
2 participants
You can’t perform that action at this time.