New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import collada with PNG or JPEGs? #61

Closed
wivlaro opened this Issue Jul 11, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@wivlaro
Contributor

wivlaro commented Jul 11, 2014

Is there any way to add PngImporter functionality to ColladaImporter? It seems to be hard-coded for TGAs only. Is there any reasonable way to get around this?

@mosra

This comment has been minimized.

Show comment
Hide comment
@mosra

mosra Jul 21, 2014

Owner

Yes, it is. I originally did only TGA support as a test and never got back to adding support for other formats. I don't want to make ColladaImporter depending on all other image importing plugins, so I must do it in some different way. I'm on it.

Owner

mosra commented Jul 21, 2014

Yes, it is. I originally did only TGA support as a test and never got back to adding support for other formats. I don't want to make ColladaImporter depending on all other image importing plugins, so I must do it in some different way. I'm on it.

@wivlaro

This comment has been minimized.

Show comment
Hide comment
@wivlaro

wivlaro Jul 21, 2014

Contributor

Awesome! I look forward to it.

Contributor

wivlaro commented Jul 21, 2014

Awesome! I look forward to it.

@mosra mosra added the feature label Jul 22, 2014

@mosra

This comment has been minimized.

Show comment
Hide comment
@mosra

mosra Jul 26, 2014

Owner

Done in mosra/magnum-plugins@31e4ea8. I had to do some infrastructure changes in Corrade and Magnum to implement this cleanly, now you can also use the new AnyImageImporter plugin to import any {TGA,PNG,JPEG} file without worrying about its type. More file types to come :-)

Owner

mosra commented Jul 26, 2014

Done in mosra/magnum-plugins@31e4ea8. I had to do some infrastructure changes in Corrade and Magnum to implement this cleanly, now you can also use the new AnyImageImporter plugin to import any {TGA,PNG,JPEG} file without worrying about its type. More file types to come :-)

@mosra mosra closed this Jul 26, 2014

@wivlaro

This comment has been minimized.

Show comment
Hide comment
@wivlaro

wivlaro Jul 27, 2014

Contributor

Wow that works great! Thanks! That was the most amazingly quick turnaround for a feature request on an open-source project. 💡

Contributor

wivlaro commented Jul 27, 2014

Wow that works great! Thanks! That was the most amazingly quick turnaround for a feature request on an open-source project. 💡

@mosra

This comment has been minimized.

Show comment
Hide comment
@mosra

mosra Jul 27, 2014

Owner

Oh, really? Thank you for the kind words :-)

Owner

mosra commented Jul 27, 2014

Oh, really? Thank you for the kind words :-)

@mosra mosra added this to the 2015.05 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment