New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port OpenGEX importer to crappy platforms #95

Closed
mosra opened this Issue May 8, 2015 · 3 comments

Comments

Projects
1 participant
@mosra
Owner

mosra commented May 8, 2015

Currently, OpenGEX importer works only on platforms with sane C++11 support. There are missing workarounds for:

  • Platforms with missing unrestricted unions (GCC <= 4.5, MSVC 2013) -- need to work around that with something like char storage[N] and accessors with ugly reinterpret_casts inside
  • Platforms with missing std::stoul(), std::stof() etc. (libc on Android, newlib on NaCl, probably also old MinGW32) -- I need base 2, base 8, base 10, base 16 and that can't be easily covered with std::istringstream
  • Platforms with list-initialization bugs (GCC <= 4.5, possibly MSVC 2013) -- that's mainly for the specification validation, but can be worked around with some explicit typing (although maintaining that will be very painful)
  • Platforms without raw string literals (GCC 4.4) -- all the tests are written with them, I'd rather drop GCC 4.4 support altogether than work around that

If you need to import OpenGEX files on any of these platforms, please comment and I'll try to do the port.

@mosra mosra added the compatibility label May 8, 2015

@mosra

This comment has been minimized.

Owner

mosra commented Sep 26, 2015

Just to clarify, OpenGEX importer works flawlessly on MSVC 2015.

@mosra

This comment has been minimized.

Owner

mosra commented Nov 26, 2016

The compatibility branch and all related nightmares were removed some time ago, so obsoleting some of these TODOs.

@mosra

This comment has been minimized.

Owner

mosra commented Nov 26, 2016

Ported to Android in mosra/magnum-plugins@8c8b398. NaCl support is currently on hold, so I'm closing this issue as resolved.

@mosra mosra closed this Nov 26, 2016

@mosra mosra added this to the 2018.02 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment