Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero-initialize utf8 buffer. #324

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
3 participants
@Tryum
Copy link

Tryum commented Mar 6, 2019

I noticed that imgui text input behave wrongly with GLFW app, here's a fix.

Thibault Jochem
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   67.84%   67.84%           
=======================================
  Files         339      339           
  Lines       17815    17815           
=======================================
  Hits        12086    12086           
  Misses       5729     5729

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d7ee7...c71466c. Read the comment docs.

@mosra mosra added this to the 2019.0b milestone Mar 7, 2019

@mosra mosra added this to TODO in Platforms via automation Mar 7, 2019

@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Mar 7, 2019

Thanks a lot! 👍 Merged in 28e300d (without the explicit memset()).

@mosra mosra closed this Mar 7, 2019

Platforms automation moved this from TODO to Done Mar 7, 2019

@Tryum

This comment has been minimized.

Copy link
Author

Tryum commented Mar 7, 2019

You're very welcome ! I enjoy a lot working with magnum, so it's my small stone to the monument ;)
I hope I'll contribute more !
I also learned a new way of default initializing arrays ;)

@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Mar 7, 2019

Haha, thanks :) Looking forward for your future contributions 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.