Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform: improve {Glfw,Sdl2}Application::exit(). #332

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
2 participants
@williamjcm
Copy link
Contributor

commented Apr 9, 2019

Now, it's possible to exit an application properly with a non-zero exit code.

On my end, I could only test the Sdl2Application version.

Review and feedback are welcome!

Platform: improve {Glfw,Sdl2}Application::exit().
Now, it's possible to specify a custom exit code.
@mosra

mosra approved these changes Apr 9, 2019

Copy link
Owner

left a comment

Looking great! 👍 To be sure before merging, I'll just wait until the CIs get sufficiently green.

@mosra mosra merged commit f4b6130 into mosra:master Apr 9, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mosra mosra added this to the 2019.0b milestone Apr 9, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Apr 9, 2019

Merged, thanks!

@mosra mosra added this to Done in Platforms Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.