Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform: improve {Glfw,Sdl2}Application. #335

Closed
wants to merge 2 commits into from

Conversation

Projects
2 participants
@williamjcm
Copy link
Contributor

commented Apr 22, 2019

Two new methods, setMinWindowSize() and setMaxWindowSize(), were added.
They use the underlying library's API to achieve their purpose.

Review/feedback welcome!

williamjcm added some commits Apr 22, 2019

Platform: improve {Glfw,Sdl2}Application.
Two new methods, setMinWindowSize() and setMaxWindowSize(), were added.
They use the underlying library's API to achieve their purpose.
Platform: add #ifdefs in GlfwApplication.
Window size limits were added in GLFW 3.2,so we make it visible only in
that case.
@mosra

mosra approved these changes Apr 22, 2019

Copy link
Owner

left a comment

Looking good! 👍 Let's just wait until the CIs pass :)

@mosra mosra added this to the 2019.0b milestone Apr 22, 2019

@mosra mosra added this to TODO in Platforms via automation Apr 22, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Apr 22, 2019

Merged in b4dac78. Thanks a lot!

@mosra mosra closed this Apr 22, 2019

Platforms automation moved this from TODO to Done Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.