Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: add buffer (un)queuing to Source. #338

Closed
wants to merge 4 commits into from

Conversation

@williamjcm
Copy link
Contributor

@williamjcm williamjcm commented May 10, 2019

And also add an implementation for Source::type().

Reviews and feedback are welcome!

And also add an implementation for Source::type().
@codecov-io
Copy link

@codecov-io codecov-io commented May 11, 2019

Codecov Report

Merging #338 into master will decrease coverage by 0.06%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   71.14%   71.07%   -0.07%     
==========================================
  Files         346      346              
  Lines       17346    17367      +21     
==========================================
+ Hits        12340    12343       +3     
- Misses       5006     5024      +18
Impacted Files Coverage Δ
src/Magnum/Audio/Source.cpp 30.3% <0%> (-11.37%) ⬇️
src/Magnum/Audio/Source.h 82.85% <100%> (+0.5%) ⬆️
src/Magnum/Math/Quaternion.h 100% <0%> (ø) ⬆️
src/Magnum/Math/Matrix4.h 100% <0%> (ø) ⬆️
src/Magnum/Math/Matrix3.h 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec10b8...f4ea06d. Read the comment docs.

Copy link
Owner

@mosra mosra left a comment

I was just about to merge and then realized the test we discussed is not here yet. Can you add it? Thank you!

Also sorry for the week-long delay, could have said this earlier 😅

src/Magnum/Audio/Source.cpp Outdated Show resolved Hide resolved
src/Magnum/Audio/Source.h Show resolved Hide resolved
@mosra mosra added this to the 2019.0b milestone May 17, 2019
@mosra mosra added this to TODO in Audio via automation May 17, 2019
@mosra
Copy link
Owner

@mosra mosra commented May 25, 2019

Merged in b9fb03a and 1104d8b, thank you! While at it, in c442c07 I added also debug output for Source::Type.

@mosra mosra closed this May 25, 2019
Audio automation moved this from TODO to Done May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Audio
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants