Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: add support for buffer loop points. #342

Closed
wants to merge 2 commits into from

Conversation

Projects
3 participants
@williamjcm
Copy link
Contributor

commented May 27, 2019

This feature requires the AL_SOFT_loop_points extension.

Also, a test for Buffer::setData() was added to BufferALTest, along with the tests for the new functions.

Review/feedback welcome!

@williamjcm williamjcm force-pushed the williamjcm:loop-points branch from e6cd76f to 98c9468 May 27, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 27, 2019

Codecov Report

Merging #342 into master will decrease coverage by 15.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage    74.3%   58.81%   -15.5%     
==========================================
  Files         346      324      -22     
  Lines       16430    14001    -2429     
==========================================
- Hits        12209     8235    -3974     
- Misses       4221     5766    +1545
Impacted Files Coverage Δ
src/Magnum/Audio/Context.cpp 60.74% <ø> (-9.69%) ⬇️
src/Magnum/Audio/Buffer.cpp 100% <100%> (ø)
src/Magnum/Audio/Buffer.h 100% <100%> (ø) ⬆️
src/Magnum/Text/Renderer.h 0% <0%> (-100%) ⬇️
src/Magnum/DebugTools/BufferData.cpp 0% <0%> (-100%) ⬇️
src/Magnum/GL/Implementation/TextureState.h 0% <0%> (-100%) ⬇️
src/Magnum/TextureTools/DistanceField.h 0% <0%> (-100%) ⬇️
src/Magnum/Text/DistanceFieldGlyphCache.h 0% <0%> (-100%) ⬇️
src/Magnum/GL/Implementation/State.h 0% <0%> (-100%) ⬇️
src/Magnum/DebugTools/ResourceManager.h 0% <0%> (-100%) ⬇️
... and 211 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8110de3...98c9468. Read the comment docs.

Audio: add support for buffer loop points.
This feature requires the AL_SOFT_loop_points extension.
Also, a test for Buffer::setData() was added to BufferALTest.

@williamjcm williamjcm force-pushed the williamjcm:loop-points branch from 98c9468 to c1d69c2 May 27, 2019

@mosra mosra added this to the 2019.0b milestone May 27, 2019

@mosra mosra added this to TODO in Audio via automation May 27, 2019

@mosra
Copy link
Owner

left a comment

Thank you! This time a bit more comments, in particular I think the Buffer could use some getters like Source has.

Show resolved Hide resolved src/Magnum/Audio/Test/BufferALTest.cpp Outdated
Show resolved Hide resolved src/Magnum/Audio/Test/BufferALTest.cpp Outdated
Show resolved Hide resolved src/Magnum/Audio/Buffer.h Outdated
Show resolved Hide resolved src/Magnum/Audio/Buffer.cpp Outdated
Show resolved Hide resolved src/Magnum/Audio/Buffer.cpp
@mosra

This comment has been minimized.

Copy link
Owner

commented Jun 1, 2019

Merged as f5302ed and 8029abc, with some very minor changes. Thank you!

@mosra mosra closed this Jun 1, 2019

Audio automation moved this from TODO to Done Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.