Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL: imageSize is not available for GLES < 3.1 #365

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@msbaines
Copy link

commented Aug 19, 2019

Fixes the following compile error:

magnum/src/Magnum/GL/Texture.h:747:44: error: no member named 'imageSize' in 'Magnum::GL::AbstractTexture::DataHelper<2>'
return DataHelper::imageSize(*this, level);
^

Mandeep Singh Baines
GL: imageSize is not available for GLES < 3.1
Fixes the following compile error:

magnum/src/Magnum/GL/Texture.h:747:44: error: no member named 'imageSize' in 'Magnum::GL::AbstractTexture::DataHelper<2>'
            return DataHelper<dimensions>::imageSize(*this, level);
                                           ^

@mosra mosra added this to the 2019.0b milestone Aug 20, 2019

@mosra mosra added this to TODO in GL via automation Aug 20, 2019

Repository owner deleted a comment from codecov-io Aug 20, 2019

Repository owner deleted a comment from codecov-io Aug 20, 2019

Repository owner deleted a comment from codecov-io Aug 20, 2019

Repository owner deleted a comment from codecov-io Aug 20, 2019

Repository owner deleted a comment from codecov-io Aug 20, 2019

Repository owner deleted a comment from codecov-io Aug 20, 2019

@mosra mosra merged commit acaf35a into mosra:master Aug 20, 2019

3 of 4 checks passed

codecov/project 67.24% (-3.99%) compared to e8a715f
Details
codecov/patch Coverage not affected when comparing e8a715f...acaf35a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

GL automation moved this from TODO to Done Aug 20, 2019

@mosra

This comment has been minimized.

Copy link
Owner

commented Aug 20, 2019

This got overlooked, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.