Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular applications #387

Merged
merged 2 commits into from Nov 8, 2019
Merged

Modular applications #387

merged 2 commits into from Nov 8, 2019

Conversation

@costashatz
Copy link
Contributor

costashatz commented Nov 7, 2019

This PR adds a mainLoopIteration() function to AbstractXApplication and GlfwApplication similar to the one that Sdl2Application has.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #387 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #387      +/-   ##
=========================================
+ Coverage    72.4%   72.4%   +<.01%     
=========================================
  Files         354     354              
  Lines       18753   18752       -1     
=========================================
  Hits        13578   13578              
+ Misses       5175    5174       -1
Impacted Files Coverage Δ
...Shaders/Implementation/CreateCompatibilityShader.h 46.15% <0%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e12ba...756c124. Read the comment docs.

@mosra mosra added this to the 2019.1c milestone Nov 8, 2019
@mosra mosra added this to TODO in Platforms via automation Nov 8, 2019
@mosra mosra merged commit 756c124 into mosra:master Nov 8, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 01e12ba...756c124
Details
codecov/project 72.4% (+<.01%) compared to 01e12ba
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Platforms automation moved this from TODO to Done Nov 8, 2019
@mosra

This comment has been minimized.

Copy link
Owner

mosra commented Nov 8, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Platforms
  
Done
3 participants
You can’t perform that action at this time.