emscripten: Remove linker only flag from compiler flags#16
emscripten: Remove linker only flag from compiler flags#16Squareys wants to merge 1 commit intomosra:masterfrom
Conversation
b8c70e3 to
44686ec
Compare
|
Thanks! I was just wondering what's up when I upgraded Emscripten a few days ago. Is it possible that this flag was needed ages ago even for the compiler? I don't remember, honestly. So I don't need this line either, right? toolchains/generic/Emscripten.cmake Line 77 in f03e62a |
|
I wouldn't suspect so, since whether generating WASM is only relevant for the byteCode => output step. But I don't know for sure (I assume the CI would have cought it, though). Yes, that shouldn't be needed either, happy to fix that :) |
|
Tested with a Corrade CI build on an ancient 1.39.6 and it worked, so I guess that confirms everything we need to know :D Merged as 8847ed0 together with the corresponding change to |
Hi @mosra !
This is a tiny one: Newer emscripten versions produce a loud warning when using linker-only flags during compilation:
I went ahead and removed it from
CMAKE_CXX_FLAGS_INIT.Best,
Jonathan