Skip to content

emscripten: Remove linker only flag from compiler flags#16

Closed
Squareys wants to merge 1 commit intomosra:masterfrom
Squareys:remove-linker-only-flag
Closed

emscripten: Remove linker only flag from compiler flags#16
Squareys wants to merge 1 commit intomosra:masterfrom
Squareys:remove-linker-only-flag

Conversation

@Squareys
Copy link
Copy Markdown
Contributor

Hi @mosra !

This is a tiny one: Newer emscripten versions produce a loud warning when using linker-only flags during compilation:

em++: warning: linker setting ignored during compilation: 'WASM' [-Wunused-command-line-argument]

I went ahead and removed it from CMAKE_CXX_FLAGS_INIT.

Best,
Jonathan

@Squareys Squareys force-pushed the remove-linker-only-flag branch from b8c70e3 to 44686ec Compare February 13, 2022 15:05
@mosra
Copy link
Copy Markdown
Owner

mosra commented Feb 13, 2022

Thanks! I was just wondering what's up when I upgraded Emscripten a few days ago. Is it possible that this flag was needed ages ago even for the compiler? I don't remember, honestly.

So I don't need this line either, right?

set(CMAKE_CXX_FLAGS_INIT "-s WASM=0")

@mosra mosra added this to the 2022.0a milestone Feb 13, 2022
@Squareys
Copy link
Copy Markdown
Contributor Author

I wouldn't suspect so, since whether generating WASM is only relevant for the byteCode => output step. But I don't know for sure (I assume the CI would have cought it, though).

Yes, that shouldn't be needed either, happy to fix that :)

@mosra
Copy link
Copy Markdown
Owner

mosra commented Feb 13, 2022

Tested with a Corrade CI build on an ancient 1.39.6 and it worked, so I guess that confirms everything we need to know :D

Merged as 8847ed0 together with the corresponding change to Emscripten.cmake, thanks! I'll update the submodule in all repos together with the iOS/ARM64 CI changes I'm doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants