From b0c7ffd6a26ca13fc4b79499ed9730cca1d00040 Mon Sep 17 00:00:00 2001
From: Mostafa Maklad <maklad@uxbert.com>
Date: Tue, 2 Jan 2018 17:09:49 +0300
Subject: [PATCH] try to check config

---
 src/Exceptions/InvalidPermissionModel.php | 11 +++++++++
 src/Exceptions/InvalidRoleModel.php       | 11 +++++++++
 src/Helpers.php                           | 16 +++++++++++++
 src/Models/Permission.php                 | 28 +++++++++++++++++------
 4 files changed, 59 insertions(+), 7 deletions(-)
 create mode 100644 src/Exceptions/InvalidPermissionModel.php
 create mode 100644 src/Exceptions/InvalidRoleModel.php

diff --git a/src/Exceptions/InvalidPermissionModel.php b/src/Exceptions/InvalidPermissionModel.php
new file mode 100644
index 0000000..2cab594
--- /dev/null
+++ b/src/Exceptions/InvalidPermissionModel.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace Maklad\Permission\Exceptions;
+
+/**
+ * Class InvalidPermissionModel
+ * @package Maklad\Permission\Exceptions
+ */
+class InvalidPermissionModel extends MakladException
+{
+}
diff --git a/src/Exceptions/InvalidRoleModel.php b/src/Exceptions/InvalidRoleModel.php
new file mode 100644
index 0000000..cf537ed
--- /dev/null
+++ b/src/Exceptions/InvalidRoleModel.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace Maklad\Permission\Exceptions;
+
+/**
+ * Class InvalidRoleModel
+ * @package Maklad\Permission\Exceptions
+ */
+class InvalidRoleModel extends MakladException
+{
+}
diff --git a/src/Helpers.php b/src/Helpers.php
index 0c76fae..977464b 100644
--- a/src/Helpers.php
+++ b/src/Helpers.php
@@ -79,4 +79,20 @@ public function getRoleDoesNotExistMessage(string $name, string $guardName): str
     {
         return "There is no role named `{$name}` for guard `{$guardName}`.";
     }
+
+    /**
+     * @return string
+     */
+    public function getInvalidRoleModelMessage(): string
+    {
+        return 'Invalid Role model in the configuration file.';
+    }
+
+    /**
+     * @return string
+     */
+    public function getInvalidPermissionModelMessage(): string
+    {
+        return 'Invalid Permission model in the configuration file.';
+    }
 }
diff --git a/src/Models/Permission.php b/src/Models/Permission.php
index 81bcd11..27daea2 100644
--- a/src/Models/Permission.php
+++ b/src/Models/Permission.php
@@ -7,6 +7,9 @@
 use Jenssegers\Mongodb\Eloquent\Model;
 use Jenssegers\Mongodb\Relations\BelongsToMany;
 use Maklad\Permission\Contracts\PermissionInterface;
+use Maklad\Permission\Contracts\RoleInterface;
+use Maklad\Permission\Exceptions\InvalidPermissionModel;
+use Maklad\Permission\Exceptions\InvalidRoleModel;
 use Maklad\Permission\Exceptions\PermissionAlreadyExists;
 use Maklad\Permission\Exceptions\PermissionDoesNotExist;
 use Maklad\Permission\Helpers;
@@ -42,6 +45,7 @@ public function __construct(array $attributes = [])
 
     /**
      * Create new Permission
+     *
      * @param array $attributes
      *
      * @return $this|\Illuminate\Database\Eloquent\Model
@@ -55,9 +59,9 @@ public static function create(array $attributes = [])
             'guard_name',
             $attributes['guard_name']
         )->first()) {
-            $name = $attributes['name'];
+            $name      = $attributes['name'];
             $guardName = $attributes['guard_name'];
-            $helpers = new Helpers();
+            $helpers   = new Helpers();
             throw new PermissionAlreadyExists($helpers->getPermissionAlreadyExistsMessage($name, $guardName));
         }
 
@@ -71,13 +75,23 @@ public static function create(array $attributes = [])
     /**
      * A permission can be applied to roles.
      * @return BelongsToMany
+     * @throws \Maklad\Permission\Exceptions\InvalidPermissionModel
+     * @throws \Maklad\Permission\Exceptions\InvalidRoleModel
      */
     public function roles(): BelongsToMany
     {
-        return $this->belongsToMany(
-            \config('permission.models.role'),
-            \config('permission.collection_names.role_has_permissions')
-        );
+        $roleModel       = \config('permission.models.role');
+        $permissionModel = \config('permission.models.permission');
+        $helpers = new Helpers();
+
+        if ($roleModel instanceof RoleInterface) {
+            throw new InvalidRoleModel($helpers->getInvalidRoleModelMessage());
+        }
+        if ($permissionModel instanceof PermissionInterface) {
+            throw new InvalidPermissionModel($helpers->getInvalidPermissionModelMessage());
+        }
+
+        return $this->belongsToMany($roleModel, $permissionModel);
     }
 
     /**
@@ -104,7 +118,7 @@ public static function findByName(string $name, $guardName = null): PermissionIn
 
         $permission = static::getPermissions()->where('name', $name)->where('guard_name', $guardName)->first();
 
-        if (! $permission) {
+        if ( ! $permission) {
             $helpers = new Helpers();
             throw new PermissionDoesNotExist($helpers->getPermissionDoesNotExistMessage($name, $guardName));
         }