show all assignees' icon #9

Merged
merged 2 commits into from May 18, 2017

Conversation

Projects
None yet
3 participants
@papix
Collaborator

papix commented Apr 18, 2017

Github has supported multiple assignees on issues and pull requests.
But, this extension doesn't support multiple assignees.

I implemented to display all assignees icon:

before

2017-04-18 22 05 27

after

2017-04-18 22 05 07

@motemen motemen added the in progress label Apr 18, 2017

@hatz48

thx! I saw your great code and commented on it.

src/ts/badgeView.ts
- <image x="${this.numberWidth + this.stateWidth}" y="0"
- width="${iconSize}" height="${iconSize}"
- xlink:href="${this.issue.assignee.avatar_url}"></image>
+ ${icons}

This comment has been minimized.

@hatz48

hatz48 Apr 18, 2017

Collaborator

I think it is necessary to join icons with empty string ''. Or does this code output extra comma like following?

<image .../image>,<image .../image>
@hatz48

hatz48 Apr 18, 2017

Collaborator

I think it is necessary to join icons with empty string ''. Or does this code output extra comma like following?

<image .../image>,<image .../image>
@papix

This comment has been minimized.

Show comment
Hide comment
@papix

papix May 17, 2017

Collaborator

@hatz48 Thank you for your comment, and sorry for my late reply...

I think it is necessary to join icons with empty string ''.

You are correct, my code was outputting extra comma...
In this commit, I fixed that using join:62e2fa8

Collaborator

papix commented May 17, 2017

@hatz48 Thank you for your comment, and sorry for my late reply...

I think it is necessary to join icons with empty string ''.

You are correct, my code was outputting extra comma...
In this commit, I fixed that using join:62e2fa8

@hatz48

This comment has been minimized.

Show comment
Hide comment
@hatz48

hatz48 May 18, 2017

Collaborator

LGTM 👍

Collaborator

hatz48 commented May 18, 2017

LGTM 👍

@hatz48 hatz48 merged commit c04dd51 into master May 18, 2017

@motemen motemen removed the in progress label May 18, 2017

@hatz48 hatz48 deleted the show-all-assignees-icon branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment