New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): remove glossy <select> effect in Safari #292
fix(ui): remove glossy <select> effect in Safari #292
Conversation
packages/ui/src/index.scss
Outdated
-moz-appearance: none; | ||
-webkit-appearance: none; | ||
appearance: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if just setting:
-moz-appearance: none; | |
-webkit-appearance: none; | |
appearance: none; | |
-webkit-appearance: caret; |
wouldn't work?
Setting appearance
to none
removes the dropdown arrow from all browsers 😞
Unfortunately, option with |
I have currently found some solution that looks good. By using The only thing is that there are still cross-browser problems (Now I believe why Safari is called the new IE). Since after Of course, in theory, we could add a fixed width select in playback controls, which would eventually make it look almost the same in both browsers. So I'd like to figure out if I should do such a "hack" for the sake of the great UI, or scrape this idea for now and leave the controls in Safari the way they are (Which of course I wouldn't want to, because the new dropdown icon looks more interesting after all) |
I think adding a fixed width, or at least a |
After a little poking around, I was able to figure out that the cause of the weird width is also the size property of input, which (again) works differently in both browsers. So I removed it in the |
This adds custom dropdown icon and sets appearance to none
Rename background to backround-color as only color has been set for controls Add more left padding for select for icon to look more centered
Now both controls are looking same on different browsers (Also removed input’s size property to fix this as well)
Awesome, thanks for the PR! |
This small CSS fix removes the "glossy" effect of tags in Safari