Repository navigation
Fix OUTPUT DIRECTORY button on WSL - #787
Merged
aarthificial merged 3 commits intoOct 18, 2023
Merged
Conversation
aarthificial
requested changes
Aug 22, 2023
Contributor
There was a problem hiding this comment.
Since the explorer variable no longer makes sense with WSL, I recommend we rewrite this function a bit to avoid this confusing explorer === 'bash' check at the end:
export function openInExplorer(file: string) {
let command: string | null = null;
let args = [file];
const os = platform();
switch (os) {
case 'win32':
command = 'explorer';
break;
case 'linux':
if (isRunningOnWSL()) {
command = 'bash';
args = ['-c', `cd ${file} && explorer.exe .`];
} else {
command = 'xdg-open';
}
break;
case 'darwin':
command = 'open';
break;
}
if (command) {
spawn(command, args, {detached: true}).unref();
} else {
console.warn(`Unsupported OS: ${os}`);
}
}
przemeksulecki
force-pushed
the
fix-output-directory-on-wsl
branch
from
August 27, 2023 11:49
0dc2538 to
5e18892
Compare
Contributor
Author
|
I did force-push because I initially forgot to add --fixup flag during committing. |
aarthificial
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR regarding the OUTPUT DIRECTORY button located in the player's video settings.
When we run
npmon WSL (Windows Subsystem for Linux) then Motion Canvas tries to execute:xdg-open <absolute-path-to-output-dir>In the case of WSL it won't work, so we can do something like this:
bash -c cd <absolute-path-to-output-dir> && explorer.exe .