feat(vite-plugin): support glob for project files - #834
Merged
Conversation
rmhartog
force-pushed
the
support-glob-files
branch
from
October 26, 2023 08:23
b5bc58a to
465f199
Compare
Contributor
|
Can we use |
Contributor
Author
Looks like that'd be a simple replacement, will pick that up soon. |
rmhartog
force-pushed
the
support-glob-files
branch
from
October 27, 2023 13:10
465f199 to
24f64f5
Compare
Contributor
Author
|
Updated to |
aarthificial
approved these changes
Oct 27, 2023
Contributor
|
Could you also update the TSDoc comments and the documentation to mention the support for globs? |
Closes: motion-canvas#324 Co-Authored-By: Guilherme Reis <guifeliper@gmail.com>
rmhartog
force-pushed
the
support-glob-files
branch
from
October 30, 2023 08:11
24f64f5 to
fa7b6a0
Compare
Contributor
Author
Do you think mentioning support like I did for now is sufficient? |
Contributor
|
Yes, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopting the stale pull request #576 because it failed CI.
Support glob patterns for project files in the vite-plugin.
Please credit @guifeliper as below if squash-merging.
Closes: #324
Co-Authored-By: Guilherme Reis guifeliper@gmail.com