feat(core & ui): add audio volume control through arrow keys - #856
Merged
Merged
Conversation
Contributor
aarthificial
requested changes
Nov 29, 2023
Contributor
Author
|
Updated your changes. UI: Hmm, the only thing stopping me would be implementing the popover component which doesn't seem to exist in the project yet. Maybe we can use something like Popper? Let's get this PR merged and I'll make a separate PR if I get around to it. |
Contributor
|
Thanks for the PR! I think Popper would be a bit of an overkill for this. (Here's a div I put inside of the volume button with |
Contributor
|
Are you currently working on this @Vija02 ? |
Contributor
Author
|
@jmaen No I'm not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds the ability to control the volume of audio through arrow keys (up and down). This will update the volume by 10% increments.
Solves #320 partially.
There's no visible UI element yet since I think some discussion on how that should look like before implementing would be good.
However, this will at least give people the option to control the volume if they know the button to press.