feat(ui): add volume slider #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarthificial
requested changes
Dec 19, 2023
Contributor
aarthificial
left a comment
aarthificial
left a comment
There was a problem hiding this comment.
Looks good!
There are just a few tweaks to the styles necessary
Contributor
Author
|
I adressed your styling improvements and updated the value calculation in the |
aarthificial
approved these changes
Dec 19, 2023
Contributor
|
Awesome, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a volume slider to adjust audio volume in addition to the existing key controls. The slider appears when hovering the sound icon, as described in #856
I had some trouble getting the default
<input type="range"/>to look consistent accross different browsers, especially with the vertical orientation, so I build a slider component from scratch.Closes #320