feat(ui): add number input dragging - #917
Merged
Merged
Conversation
aarthificial
requested changes
Jan 11, 2024
aarthificial
left a comment
Contributor
There was a problem hiding this comment.
I think we should add the following handler to the input as well:
onKeyDown={event => {
if (event.key === 'Enter') {
inputRef.current.blur();
}
if (event.key === 'Escape') {
inputRef.current.value = currentValue.toString();
inputRef.current.blur();
}
}}Co-authored-by: Jacob <64662184+aarthificial@users.noreply.github.com>
Contributor
Author
|
I think I adressed all your requested changes. Apparently the pipeline failed to build, but the error seems to have occured in |
aarthificial
approved these changes
Jan 12, 2024
Contributor
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
NumberInputcomponent that supports dragging to edit numbers. When hovering over the input, the cursor is a left-right arrow to indicate the dragging option. For the dragging behavior, thePointerLockAPI is used.In order to edit the value manually via keyboard input, users can click the component without dragging. Dragging is then disabled and the cursor switches to a regular text cursor, allowing text selection. Up and down arrow keys are also supported through the regular
<input type="number"/>element.The new
NumberInputalso supportsmin,maxandstepproperties for input via the arrow keys and via dragging.Closes #799
input-dragging.mov