Skip to content

[FIX] unsetting hop on host #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018
Merged

[FIX] unsetting hop on host #74

merged 1 commit into from
Nov 16, 2018

Conversation

vdaviot
Copy link

@vdaviot vdaviot commented Nov 6, 2018

Which issue this PR fixes

  • Commit 101b363 fixes:
    • #70: Unsetting a hop from a host unsets the hops from all the hosts it is set on

What this PR does / why we need it

The command host update --unset-hop <host> removed the host's hop from every hosts and not only the given one.
It now remove the hop only on the given host.

Copy link
Owner

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants