Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of search queries by find_census_vectors #150

Closed
baranovskypd opened this issue Jun 28, 2020 · 3 comments
Closed

Inconsistent handling of search queries by find_census_vectors #150

baranovskypd opened this issue Jun 28, 2020 · 3 comments
Labels

Comments

@baranovskypd
Copy link

@baranovskypd baranovskypd commented Jun 28, 2020

(1) In find_census_vectors(), type = c("male", "female") sometimes works, but throws a warning. Try:

find_census_vectors("full year, full time", "CA16",
                    type = c("male", "female"),
                    query_type = "exact")

Could you maybe remove the warning? Just please don't remove the ability to return data for both genders with one command, it is very handy.

(2) And sometimes type = c("male", "female") doesn't work:

find_census_vectors("part year and/or part time", 
                    "CA16",
                    type = c("male", "female"),
                    query_type = "exact")

Says 'No exact matches found. Please check spelling and try again or consider using semantic or keyword search.' However, this works (note exact same query term):

find_census_vectors("part year and/or part time", 
                    "CA16",
                    type = "male",
                    query_type = "exact")

Could you please make this consistent and allow to set type = c("male", "female")?

@dshkol dshkol added bug to do labels Jul 7, 2020
@dshkol
Copy link
Collaborator

@dshkol dshkol commented Jul 7, 2020

Thanks for flagging this. Apologies, thought I had written a response earlier. Will look into this asap - agree should be addressed.

@dshkol
Copy link
Collaborator

@dshkol dshkol commented Jul 7, 2020

Fixed in #152 - thanks again for the heads up @baranovskypd.

@dshkol dshkol closed this Jul 7, 2020
@baranovskypd
Copy link
Author

@baranovskypd baranovskypd commented Jul 7, 2020

You are welcome. Thanks for the quick update, and keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.