This repository has been archived by the owner on May 4, 2024. It is now read-only.
[evm][move package] make --arch ethereum present in all builds, but return an error if feature evm-backend isn't enabled
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return an error if feature `evm-backend` isn't enabled
wrwg
approved these changes
May 5, 2022
| config.compile_package_evm(&rerooted_path, &mut std::io::stderr())?; | ||
|
|
||
| #[cfg(not(feature = "evm-backend"))] | ||
| bail!("The Ethereum architecture is not supported because move-cli was not compiled with feature flag `evm-backend`."); |
10 tasks
brson
added a commit
to brson/move
that referenced
this pull request
Apr 27, 2023
brson
added a commit
to brson/move
that referenced
this pull request
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
--arch ethereumoption is only present when featureevm-backendis enabled, which ended up causing some confusion. This PR makes the option always available, but return an error ifevm-backendisn't enabled when invoked.