From 91e6f17e643093b485b0219fc1ec970bf5ac253c Mon Sep 17 00:00:00 2001
From: "David V. Lu!!" <davidvlu@gmail.com>
Date: Tue, 7 Jun 2022 12:39:26 -0400
Subject: [PATCH] [MSA] Virtual Destructors (#1324)

---
 .../include/moveit_setup_framework/config.hpp                   | 2 ++
 .../include/moveit_setup_framework/generated_file.hpp           | 2 ++
 .../include/moveit_setup_framework/qt/setup_step_widget.hpp     | 2 ++
 .../include/moveit_setup_framework/setup_step.hpp               | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/config.hpp b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/config.hpp
index 14eac2f768..5607f33127 100644
--- a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/config.hpp
+++ b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/config.hpp
@@ -57,6 +57,8 @@ MOVEIT_CLASS_FORWARD(SetupConfig);  // Defines SetupConfigPtr, ConstPtr, WeakPtr
 class SetupConfig
 {
 public:
+  virtual ~SetupConfig() = default;
+
   /**
    * @brief Called after construction to initialize the step
    * @param config_data Pointer to all the other configs
diff --git a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/generated_file.hpp b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/generated_file.hpp
index 0798d21297..0b50b7fd1d 100644
--- a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/generated_file.hpp
+++ b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/generated_file.hpp
@@ -71,6 +71,8 @@ class GeneratedFile : public std::enable_shared_from_this<GeneratedFile>
   {
   }
 
+  virtual ~GeneratedFile() = default;
+
   /**
    * @brief Returns the path relative to the configuration package root
    */
diff --git a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/qt/setup_step_widget.hpp b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/qt/setup_step_widget.hpp
index f32e7b5ad3..713cfdb9a3 100644
--- a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/qt/setup_step_widget.hpp
+++ b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/qt/setup_step_widget.hpp
@@ -49,6 +49,8 @@ class SetupStepWidget : public QWidget
 {
   Q_OBJECT
 public:
+  virtual ~SetupStepWidget() = default;
+
   /**
    * @brief Called after construction to initialize the step
    * @param parent_node Shared pointer to the parent node
diff --git a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/setup_step.hpp b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/setup_step.hpp
index 79e05ca37f..e152d3902b 100644
--- a/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/setup_step.hpp
+++ b/moveit_setup_assistant/moveit_setup_framework/include/moveit_setup_framework/setup_step.hpp
@@ -46,6 +46,8 @@ namespace moveit_setup
 class SetupStep
 {
 public:
+  virtual ~SetupStep() = default;
+
   /**
    * @brief Called after construction to initialize the step
    * @param parent_node Shared pointer to the parent node