From f7fb724f762690d11f542e2cedc17a7e573bee6b Mon Sep 17 00:00:00 2001 From: RoboticsYY Date: Wed, 23 Sep 2020 21:36:44 +0800 Subject: [PATCH] Remove unnecessary comments --- .../src/motion_planning_frame.cpp | 1 - .../src/motion_planning_frame_context.cpp | 3 --- .../src/motion_planning_frame_objects.cpp | 7 ------- .../src/motion_planning_frame_scenes.cpp | 5 ----- .../src/motion_planning_frame_states.cpp | 5 ----- 5 files changed, 21 deletions(-) diff --git a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame.cpp b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame.cpp index 056d7c676bb..27e11c42aac 100644 --- a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame.cpp +++ b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame.cpp @@ -392,7 +392,6 @@ void MotionPlanningFrame::changePlanningGroupHelper() std::shared_ptr tf_buffer = moveit::planning_interface::getSharedTF(); #endif move_group_.reset(new moveit::planning_interface::MoveGroupInterface(node_, opt, tf_buffer, rclcpp::Duration(30))); - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) move_group_->setConstraintsDatabase(ui_->database_host->text().toStdString(), ui_->database_port->value()); } diff --git a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_context.cpp b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_context.cpp index a85cd2fef97..4a394615531 100644 --- a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_context.cpp +++ b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_context.cpp @@ -33,7 +33,6 @@ *********************************************************************/ /* Author: Ioan Sucan */ -// TODO (ddengster): Enable when moveit_ros_warehouse is ported #include #include #include @@ -102,7 +101,6 @@ void MotionPlanningFrame::computeDatabaseConnectButtonClicked() { RCLCPP_INFO(LOGGER, "Connect to database: {host: %s, port: %d}", ui_->database_host->text().toStdString().c_str(), ui_->database_port->value()); - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { planning_scene_storage_.reset(); @@ -202,7 +200,6 @@ void MotionPlanningFrame::computeDatabaseConnectButtonClickedHelper(int mode) void MotionPlanningFrame::computeResetDbButtonClicked(const std::string& db) { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (db == "Constraints" && constraints_storage_) constraints_storage_->reset(); else if (db == "Robot States" && robot_state_storage_) diff --git a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_objects.cpp b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_objects.cpp index 9c5142806de..1187856546f 100644 --- a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_objects.cpp +++ b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_objects.cpp @@ -33,7 +33,6 @@ *********************************************************************/ /* Author: Ioan Sucan, Mario Prats */ -// TODO (ddengster): Enable when moveit_ros_warehouse is ported #include #include @@ -496,7 +495,6 @@ void MotionPlanningFrame::copySelectedCollisionObject() void MotionPlanningFrame::computeSaveSceneButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { moveit_msgs::msg::PlanningScene msg; @@ -519,7 +517,6 @@ void MotionPlanningFrame::computeSaveQueryButtonClicked(const std::string& scene { moveit_msgs::msg::MotionPlanRequest mreq; constructPlanningRequest(mreq); - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { try @@ -539,7 +536,6 @@ void MotionPlanningFrame::computeSaveQueryButtonClicked(const std::string& scene void MotionPlanningFrame::computeDeleteSceneButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { QList sel = ui_->planning_scene_tree->selectedItems(); @@ -578,7 +574,6 @@ void MotionPlanningFrame::computeDeleteSceneButtonClicked() void MotionPlanningFrame::computeDeleteQueryButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { QList sel = ui_->planning_scene_tree->selectedItems(); @@ -649,7 +644,6 @@ void MotionPlanningFrame::checkPlanningSceneTreeEnabledButtons() void MotionPlanningFrame::computeLoadSceneButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { QList sel = ui_->planning_scene_tree->selectedItems(); @@ -706,7 +700,6 @@ void MotionPlanningFrame::computeLoadSceneButtonClicked() void MotionPlanningFrame::computeLoadQueryButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { QList sel = ui_->planning_scene_tree->selectedItems(); diff --git a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_scenes.cpp b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_scenes.cpp index 52e12d83259..008fe290978 100644 --- a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_scenes.cpp +++ b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_scenes.cpp @@ -33,7 +33,6 @@ *********************************************************************/ /* Author: Ioan Sucan */ -// TODO (ddengster): Enable when moveit_ros_warehouse is ported #include #include #include @@ -64,7 +63,6 @@ static const rclcpp::Logger LOGGER = rclcpp::get_logger("moveit_ros_visualizatio void MotionPlanningFrame::saveSceneButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { const std::string& name = planning_display_->getPlanningSceneRO()->getName(); @@ -123,7 +121,6 @@ void MotionPlanningFrame::planningSceneItemClicked() void MotionPlanningFrame::saveQueryButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (planning_scene_storage_) { QList sel = ui_->planning_scene_tree->selectedItems(); @@ -214,7 +211,6 @@ void MotionPlanningFrame::warehouseItemNameChanged(QTreeWidgetItem* item, int co { if (item->text(column) == item->toolTip(column) || item->toolTip(column).length() == 0) return; - // TODO (ddengster): Enable when moveit_ros_warehouse is ported moveit_warehouse::PlanningSceneStoragePtr planning_scene_storage = planning_scene_storage_; if (!planning_scene_storage) return; @@ -262,7 +258,6 @@ void MotionPlanningFrame::warehouseItemNameChanged(QTreeWidgetItem* item, int co void MotionPlanningFrame::populatePlanningSceneTreeView() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported moveit_warehouse::PlanningSceneStoragePtr planning_scene_storage = planning_scene_storage_; if (!planning_scene_storage) return; diff --git a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_states.cpp b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_states.cpp index 3822109c458..04473969ec8 100644 --- a/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_states.cpp +++ b/moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_frame_states.cpp @@ -33,7 +33,6 @@ *********************************************************************/ /* Author: Mario Prats, Ioan Sucan */ -// TODO (ddengster): Enable when moveit_ros_warehouse is ported #include #include @@ -61,7 +60,6 @@ void MotionPlanningFrame::populateRobotStatesList() void MotionPlanningFrame::loadStateButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (robot_state_storage_) { bool ok; @@ -81,7 +79,6 @@ void MotionPlanningFrame::loadStateButtonClicked() void MotionPlanningFrame::loadStoredStates(const std::string& pattern) { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported std::vector names; try { @@ -151,7 +148,6 @@ void MotionPlanningFrame::saveRobotStateButtonClicked(const moveit::core::RobotS robot_states_.insert(RobotStatePair(name, msg)); // Save to the database if connected - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (robot_state_storage_) { try @@ -211,7 +207,6 @@ void MotionPlanningFrame::setAsGoalStateButtonClicked() void MotionPlanningFrame::removeStateButtonClicked() { - // TODO (ddengster): Enable when moveit_ros_warehouse is ported if (robot_state_storage_) { // Warn the user