Skip to content

WIP: HPP FCL Plugin#1521

Closed
vatanaksoytezer wants to merge 7 commits intomoveit:mainfrom
vatanaksoytezer:vatan/hpp_fcl_plugin
Closed

WIP: HPP FCL Plugin#1521
vatanaksoytezer wants to merge 7 commits intomoveit:mainfrom
vatanaksoytezer:vatan/hpp_fcl_plugin

Conversation

@vatanaksoytezer
Copy link
Contributor

Adresses #1435 by creating a new hpp-fcl plugin for MoveIt. Binaries of hpp-fcl are due to be available on tomorrow's sync so I would wait for that at least.

@vatanaksoytezer vatanaksoytezer marked this pull request as draft August 16, 2022 15:18
@simonschmeisser
Copy link
Contributor

Very interesting, just a short general comment: When copying and modifying files it's nice to do this in separate commits so it's easier to see in github what changes were necessary besides renaming

@vatanaksoytezer
Copy link
Contributor Author

Very interesting, just a short general comment: When copying and modifying files it's nice to do this in separate commits so it's easier to see in github what changes were necessary besides renaming

Thank you for the suggestion, I'll revise the commit history as soon as this is ready for reviews. I need to get some non-moveit work this week but I'm hoping I can get things going next week.

@simonschmeisser
Copy link
Contributor

simonschmeisser commented Jan 2, 2023

For MoveIt 1 HPP FCL is not extremely impressive unfortunately
grafik

The slight lead in the last test is probably the "twice as fast" mesh-mesh narrow phase collision checker

@mergify
Copy link

mergify bot commented May 8, 2023

This pull request is in conflict. Could you fix it @vatanaksoytezer?

1 similar comment
@mergify
Copy link

mergify bot commented Aug 11, 2023

This pull request is in conflict. Could you fix it @vatanaksoytezer?

@tylerjw
Copy link
Member

tylerjw commented Aug 23, 2023

It looks like this PR is no longer being worked on as it was determined it did not offer the hoped for performance benefits.

@tylerjw tylerjw closed this Aug 23, 2023
@simonschmeisser
Copy link
Contributor

Just for completeness: hpp fcl does offer a newer api for collision checks and this might speed up things in fact. Also hpp fcl might be faster at the narrow phase, especially mesh to mesh, which my benchmarks do not test that well. I still hope to finish the MoveIt 1 PR and then this could be ported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants