diff --git a/moveit_core/kinematics_metrics/CMakeLists.txt b/moveit_core/kinematics_metrics/CMakeLists.txt index 8438c8641d..1fa339f946 100644 --- a/moveit_core/kinematics_metrics/CMakeLists.txt +++ b/moveit_core/kinematics_metrics/CMakeLists.txt @@ -3,11 +3,14 @@ set(MOVEIT_LIB_NAME moveit_kinematics_metrics) add_library(${MOVEIT_LIB_NAME} src/kinematics_metrics.cpp) set_target_properties(${MOVEIT_LIB_NAME} PROPERTIES VERSION "${${PROJECT_NAME}_VERSION}") -target_link_libraries(${MOVEIT_LIB_NAME} moveit_robot_state ${catkin_LIBRARIES} ${urdfdom_LIBRARIES} ${urdfdom_headers_LIBRARIES} ${Boost_LIBRARIES}) -add_dependencies(${MOVEIT_LIB_NAME} ${catkin_EXPORTED_TARGETS}) +ament_target_dependencies(${MOVEIT_LIB_NAME} + moveit_robot_state + urdf + urdfdom_headers + visualization_msgs) install(TARGETS ${MOVEIT_LIB_NAME} - ARCHIVE DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION} - LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}) + LIBRARY DESTINATION lib + ARCHIVE DESTINATION lib) -install(DIRECTORY include/ DESTINATION ${CATKIN_GLOBAL_INCLUDE_DESTINATION}) +install(DIRECTORY include/ DESTINATION include) diff --git a/moveit_core/kinematics_metrics/src/kinematics_metrics.cpp b/moveit_core/kinematics_metrics/src/kinematics_metrics.cpp index 71289f831d..50dda46b0a 100644 --- a/moveit_core/kinematics_metrics/src/kinematics_metrics.cpp +++ b/moveit_core/kinematics_metrics/src/kinematics_metrics.cpp @@ -38,9 +38,13 @@ #include #include #include +#include "rclcpp/rclcpp.hpp" namespace kinematics_metrics { + +rclcpp::Logger LOGGER = rclcpp::get_logger("moveit").get_child("kinematics_metrics"); + double KinematicsMetrics::getJointLimitsPenalty(const robot_state::RobotState& state, const robot_model::JointModelGroup* joint_model_group) const { @@ -123,7 +127,7 @@ bool KinematicsMetrics::getManipulabilityIndex(const robot_state::RobotState& st manipulability_index = 1.0; for (unsigned int i = 0; i < singular_values.rows(); ++i) { - ROS_DEBUG_NAMED("kinematics_metrics", "Singular value: %d %f", i, singular_values(i, 0)); + RCLCPP_DEBUG(LOGGER, "Singular value: %d %f", i, singular_values(i, 0)); manipulability_index *= singular_values(i, 0); } // Get manipulability index @@ -146,7 +150,7 @@ bool KinematicsMetrics::getManipulabilityIndex(const robot_state::RobotState& st manipulability_index = 1.0; for (unsigned int i = 0; i < singular_values.rows(); ++i) { - ROS_DEBUG_NAMED("kinematics_metrics", "Singular value: %d %f", i, singular_values(i, 0)); + RCLCPP_DEBUG(LOGGER, "Singular value: %d %f", i, singular_values(i, 0)); manipulability_index *= singular_values(i, 0); } // Get manipulability index @@ -218,8 +222,10 @@ bool KinematicsMetrics::getManipulability(const robot_state::RobotState& state, Eigen::MatrixXd jacobian = state.getJacobian(joint_model_group); Eigen::JacobiSVD svdsolver(jacobian.topLeftCorner(3, jacobian.cols())); Eigen::MatrixXd singular_values = svdsolver.singularValues(); - for (int i = 0; i < singular_values.rows(); ++i) - ROS_DEBUG_NAMED("kinematics_metrics", "Singular value: %d %f", i, singular_values(i, 0)); + for (int i = 0; i < singular_values.rows(); ++i){ + RCLCPP_DEBUG(LOGGER, "Singular value: %d %f", i, singular_values(i, 0)); + } + manipulability = penalty * singular_values.minCoeff() / singular_values.maxCoeff(); } else @@ -227,8 +233,9 @@ bool KinematicsMetrics::getManipulability(const robot_state::RobotState& state, Eigen::MatrixXd jacobian = state.getJacobian(joint_model_group); Eigen::JacobiSVD svdsolver(jacobian); Eigen::MatrixXd singular_values = svdsolver.singularValues(); - for (int i = 0; i < singular_values.rows(); ++i) - ROS_DEBUG_NAMED("kinematics_metrics", "Singular value: %d %f", i, singular_values(i, 0)); + for (int i = 0; i < singular_values.rows(); ++i){ + RCLCPP_DEBUG(LOGGER, "Singular value: %d %f", i, singular_values(i, 0)); + } manipulability = penalty * singular_values.minCoeff() / singular_values.maxCoeff(); } return true;