Fix DropRole being executed on a dropped database #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitman99
approved these changes
Dec 22, 2021
Member
|
Hi @pcallewaert thank you for your contribution! Sorry for such a delay getting this merged - I have very limited time maintaining this project this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Since using the dropOnDelete flag for the Postgres object, it occurred that the operator was in a crash loop. It was always crashing on the Reconcile loop for PostgresUser because the database was already dropped.
It happens when our ArgoCD deployment deletes the application, and eventually the Postgres object is first removed before the PostgresUser.
I did a small refactor of GetConnection to be able to get the pq error code out of it, and in DropRole I check if the error is the error code for database does not exists.
Not sure if this is the best solution, but I've deployed this fix this week and so far it did not trigger the crash loop anymore.