New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji regex #648

Merged
merged 6 commits into from May 18, 2018

Conversation

Projects
None yet
2 participants
@mirabilos
Contributor

mirabilos commented May 18, 2018

As discussed IRL, this adds inline Emoji support code CompiledEmoji.php (generated from compile-file-list.sh) and a new MovimEmoji.php class, plus a testsuite replace-test.php and test-all-images.sh, into a temporary emoji/ directory for you to move into its proper place and namespace it.

The MovimEmoji.php should completely supercede the code embedded in app/helpers/StringHelper.php, which should just (auto)load the new file instead.

mirabilos added some commits May 18, 2018

@edhelas edhelas self-assigned this May 18, 2018

@edhelas edhelas added the enhancement label May 18, 2018

@edhelas edhelas added this to the 0.14 milestone May 18, 2018

@edhelas edhelas merged commit d7d638f into movim:master May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment