An Asterisk service adapter and another minor API tweak #2

Merged
merged 2 commits into from Apr 12, 2012

Conversation

Projects
None yet
2 participants
@russellb
Contributor

russellb commented Jan 14, 2012

No description provided.

russellb added some commits Jan 14, 2012

return self from SFile.copy_to()
This method wasn't returning anything.  returning self allows it to be
used in some more ways, like:

   sfiles = [SFile(tfile).copy_to(basedir)
   			for tfile in files if os.access(tfile, os.R_OK)]
@russellb

This comment has been minimized.

Show comment Hide comment
@russellb

russellb Jan 14, 2012

Contributor

I started with the Httpd adapter when writing the Asterisk adapter. It was pretty easy to write.

A bit of feedback ... It seems like the pattern of having services that just have a list of files/directories that need to be backed up will be very common. There's probably some more room for writing some common code for that to reduce the diff between the two service adapters.

Contributor

russellb commented Jan 14, 2012

I started with the Httpd adapter when writing the Asterisk adapter. It was pretty easy to write.

A bit of feedback ... It seems like the pattern of having services that just have a list of files/directories that need to be backed up will be very common. There's probably some more room for writing some common code for that to reduce the diff between the two service adapters.

@movitto

This comment has been minimized.

Show comment Hide comment
@movitto

movitto Apr 12, 2012

Owner

Hey Russel, sorry about the delay, am just finally able to get back to being able to hack on Snap, will be ramping up development on it again in the upcoming weeks / months.

Thanks for the patches, will merge them in momentarily. Agree on extracting common bits out for modules which just require some simple filesystem operations inorder to perform backup / restore operations. Will look into this abstraction in the near future (as well as abstracting some more of the package management system stuff so we don't have to have explicit yum / apt calls in the modules).

Appreciate it!

Owner

movitto commented Apr 12, 2012

Hey Russel, sorry about the delay, am just finally able to get back to being able to hack on Snap, will be ramping up development on it again in the upcoming weeks / months.

Thanks for the patches, will merge them in momentarily. Agree on extracting common bits out for modules which just require some simple filesystem operations inorder to perform backup / restore operations. Will look into this abstraction in the near future (as well as abstracting some more of the package management system stuff so we don't have to have explicit yum / apt calls in the modules).

Appreciate it!

@russellb

This comment has been minimized.

Show comment Hide comment
@russellb

russellb Apr 12, 2012

Contributor

Cool, no worries on the delay. It was nice to meet your briefly at FUDCon. That's when I was looking at this.

Contributor

russellb commented Apr 12, 2012

Cool, no worries on the delay. It was nice to meet your briefly at FUDCon. That's when I was looking at this.

@movitto movitto merged commit e7cffd6 into movitto:master Apr 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment