feature for drop_element #453

Closed
jmiridis opened this Issue Dec 30, 2011 · 4 comments

Projects

None yet

3 participants

@jmiridis

I'm currently using plupload 1.5.1.1 and found out that the 'drop_element' option only works if the value supplied is a string containing the id of the drop element.

It would be very helpful, and I guess code change would be minimal, if this option would also allow a jQuery element to be passed as parameter not just a string.

@emirotin
emirotin commented Jan 6, 2012

+1 for this, we often don't want assigning IDs as uploader is dynamically created, and we want to pick the element by class from the given container.

jQuery object is not necessary, it could be plain DOM object, and jQuery users could do $('selector').get(0)

@jmiridis
jmiridis commented Jan 6, 2012

I completely agree with emirotin. Accepting a DOM element would be enough.
I suggest to implement that feature for the 'browse_button' option as well.

@emirotin
emirotin commented Jan 6, 2012

yep, that's what I meant - ability to specify DOM object everywhere the ID is currently required

@jayarjo
Member
jayarjo commented Jan 7, 2012

We've been thinking to include support for this. So probably will get into next release.

@jayarjo jayarjo added a commit that referenced this issue Feb 24, 2013
@jayarjo jayarjo Underline the fact that DOM elements can now be used directly for bro…
…wse_button and drop_element options. Address #55, #283, #440, #453, #494.
355a952
@jayarjo jayarjo closed this Feb 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment