Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix: Flash Runtime doesn't load in Chrome on Windows and Linux (PluploadQueue) #539

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

Related to/fixes issues: #532 #262 (and probably #276)

A container with no content and height 100% caused an inline style of "height:0" to be applied, which prevents the widget/queue from initing.
#532 fixes this issue by setting min-height and min width to 1px.

I fix this issue by not setting the height (letting it be auto). It seems that the heights are set to pixel values later on, so the "auto" assumed value gets overwritten.

Bump.

I'd like to see this pull, or at least some other kind of warning thrown when plupload is being called on an empty div. Right now the page "hangs" for about 15 seconds, before throwing a meaningless error. I didn't know I /had/ to provide replacement content, or flash would fail to load.

I think this pull is better than #532 because it allows the user to use the CSS from a stylesheet to set the min-height and min-width if they so desire. The other solution would override the stylesheet min-width/height with inline styles.

Plus, mine is less code.

I want to clean up my hub, and I see that the related bug #532 was addressed in Plupload 2 so this pull is also irrelevant.

G'day.

@whitehat101 whitehat101 closed this Feb 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment