Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix: Flash Runtime doesn't load in Chrome on Windows and Linux (PluploadQueue) #539
A container with no content and height 100% caused an inline style of "height:0" to be applied, which prevents the widget/queue from initing.
I fix this issue by not setting the height (letting it be auto). It seems that the heights are set to pixel values later on, so the "auto" assumed value gets overwritten.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I'd like to see this pull, or at least some other kind of warning thrown when plupload is being called on an empty div. Right now the page "hangs" for about 15 seconds, before throwing a meaningless error. I didn't know I /had/ to provide replacement content, or flash would fail to load.
I think this pull is better than #532 because it allows the user to use the CSS from a stylesheet to set the min-height and min-width if they so desire. The other solution would override the stylesheet min-width/height with inline styles.
Plus, mine is less code.