Fix for Issue #605 (HTML5 input stacking in dialogs) - updated pull #612

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@stevemayhew

Hello, here's code and a couple of demo fiddles that fixes the issue #605 with z-index with WebKit browsers for HTML5. I've tested this code in Safari 5, Chrome 21. Firefox 12+. The two jsFiddles make it pretty easy to test on any other browsers you have.

I appreciate your considering the fix. I also have a fix in the works for the issue with IE9 positioning (issue with plupload.getPos() logic) when there is a min/max width set on body, if you are happy with this fix I'll share that one next.

Thanks!
Steve

Note the later commit, 3ba30df, reverts change 29126ae as that change was a temporary workaround to the real issue. Commit 3ba30df is the actual fix.

stevemayhew added some commits Aug 9, 2012
@stevemayhew stevemayhew Fixes issue with <input type="file"> click() method on WebKit
The <input type="file"> on WebKit silently ignores the click() method
when the handler calling it comes from a button in a jQuery dialog.
29126ae
@stevemayhew stevemayhew Fix for HTML5 input z-index (issue #605)
To work properly in qTip's and jQuery modal dialogs in WebKit browsers
the input container must be 1 z-index below the button but not below
any other prior elements (like another qTip or a modal dialog's model
glasspane (the ui-widget-overlay).

This issue (#605) was caused because the existing code does not
consider the "current stacking context" when attempting to determine
the z-index of the browse button.

Here is a jsFiddle
(http://jsfiddle.net/stevemayhew/VQ5NP/4/embedded/result/) that fixes
the bug. With this verison of plupload and the snipit from the HTML5
change.  And lastly, here is the jsFiddle that demonstrates the bug:
http://jsfiddle.net/stevemayhew/PhCsp/embedded/result/
3ba30df
@stevemayhew
Owner

Please ignore this commit, it was a temporary work around for the root issue. I can remove it from the pull request if it is a problem for you to ignore it.

@stevemayhew

Note this change reverts back a temporary fix made by commit 29126ae

@stevemayhew

This is the net of the fix, it uses a new function to either get the specific z-index of the browse button element, or the z-index of the stacking context containing the button, or 0, if the z-index is defaulted

@jayarjo
Member
jayarjo commented Feb 5, 2013

Have you tried to put Plupload structure (browse_button) into a container and passing it's id as a value for container option? It is meant to be used to solve such and similar issues.

@jayarjo jayarjo closed this Feb 6, 2013
@stevemayhew

Great, did you even look at the jsFiddles? In the future what motivation do we have to waste our time sharing back fixes with a product you commercially license? Many issues have been fixed by this, including being able to put the flash browse button in a jQuery dialog.

@jayarjo
Member
jayarjo commented Feb 7, 2013

Yes I checked. This problem is easily solved by putting browse_button and Plupload structure into the same container, by passing container's id as a value for container option in Plupload configuration. In Plupload 2 we even try to it do it automatically, where possible.

@stevemayhew

I think your missing the point of how people are using it putting the button into a jQuery dialog. Id'ing a container will not work. But, as you wish we will keep our code that is working with the change in the pull request. You can do with it as you wish

On Feb 6, 2013, at 11:48 PM, Davit Barbakadze notifications@github.com wrote:

Yes I checked. This problem is easily solved by putting browse_button and Plupload structure into the same container, by passing container's id as a value for container option in Plupload configuration. In Plupload 2 we even try to it do it automatically, where possible.


Reply to this email directly or view it on GitHub.

@jayarjo
Member
jayarjo commented Feb 8, 2013

What is the point we are missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment