Skip to content
Browse files

fix mochitest ui, add comments

  • Loading branch information...
1 parent 1ca122f commit 3f3427a91cc9218bc9eabb624c0e690716b0fe49 @malini malini committed Sep 27, 2011
Showing with 7 additions and 9 deletions.
  1. +0 −7 src/dashboard/html/index.html
  2. +7 −2 src/dashboard/html/js/dashboard.js
View
7 src/dashboard/html/index.html
@@ -116,11 +116,6 @@
<option selected>any</option>
</select>
<br/>
- <label>Test: </label>
- <select name="test">
- <option selected>any</option>
- </select>
- <br/>
<label>Platform: </label>
<select name="platform">
<option>win32</option>
@@ -147,6 +142,4 @@
<div id="container-run"></div>
<div id="container-load"></div>
</script>
-
-
</html>
View
9 src/dashboard/html/js/dashboard.js
@@ -1,3 +1,7 @@
+/*
+TODO: this code needs some *serious* refactoring.
+ - Received suggestion to use knockout.js to bind ui changes to changes in your data model: http://knockoutjs.com/
+*/
function show_loading(){
//Clear the display divs and show loading gif
$('#content-main').html("<div id='loading' style='margin:0 auto; padding-top:20px;'><center><span style='font-weight:200; font-size:200%;'>Loading...</span><br/><img height='32' width='32' src='./assets/images/loading.gif' alt='' /></center></div>");
@@ -515,8 +519,8 @@ function show_mochi_charts(params, names){
//Chart is now made, so update DOM:
- $("#container-run").prepend('<form id="run_nameselector">Process Name: <select name="name" id="run_name"><option>none selected</option></select><input type="submit" name="submit" value="Change data"/></form>');
- $("#container-load").prepend('<form id="load_nameselector">Process Name: <select name="name" id="load_name"><option>none selected</option></select><input type="submit" name="submit" value="Change data"/></form>');
+ $("#container-run").prepend('<form id="run_nameselector">Test Name: <select name="name" id="run_name"><option>none selected</option></select><input type="submit" name="submit" value="Change data"/></form>');
+ $("#container-load").prepend('<form id="load_nameselector">Test Name: <select name="name" id="load_name"><option>none selected</option></select><input type="submit" name="submit" value="Change data"/></form>');
//HACK USES GLOBAL VARIABLEs.
@@ -636,6 +640,7 @@ function populate_fields(){
//Now we write into the form all the different option types
+ //TODO: not convinced this actually works
for(var x in fields["tree"]){
$('#tree').append('<option>'+x+'</option>');
}

0 comments on commit 3f3427a

Please sign in to comment.
Something went wrong with that request. Please try again.