Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Why do things break when dom.webcomponents.enabled = true? #124

Closed
sole opened this Issue Feb 6, 2014 · 6 comments

Comments

Projects
None yet
3 participants
Contributor

sole commented Feb 6, 2014

Apparently some components in Brick don't work nicely when web components support is enabled in Nightly, which sounds pretty bad (according to @potch webcomponents.enabled "break the world", urgh)

My very limited report consisting in testing only two different things shows wild differences:

  • flipbox works
  • calendar doesn't (TypeError: this.xtag.calObj is undefined)

We should look into this, if only because well, it works on Chrome Canary which does have support for web components enabled too.

Contributor

potch commented Feb 7, 2014

The implementation of WC stuff in Firefox lags behind the specification, sometimes considerably. I'm hesitant to dig into this until there's some stability in the spec and in the various browser implementations.

@potch potch added the compatibility label Feb 7, 2014

Contributor

sole commented Feb 10, 2014

Since I'm the curious type and I'm investigating the usage/implementation of "raw" web components, I will have a look and see if I find what it actually breaking. I don't promise anything but I'll give it a go, because I find it very annoying to have to enable/disable things when browsing :-)

@sole sole self-assigned this Feb 10, 2014

Contributor

sole commented Feb 27, 2014

@potch I tried this with the latest Nightly, which has the standard-compliant document.registerElement implementation, anddddddd... IT WORKSSSSSSSS!

So very exciting.

I also tried to trace what the root of the issue was, past week. The only thing I could find is that the this.xtag object was created when the created callback was called. But with the old implementation that never happened. Sadly I couldn't find where was that skipped-between the polyfill and the rest of the magic and my jetlag there was too much haze in my brain :-)

Anyway, we're done here. Happily closing! 🍸

@sole sole closed this Feb 27, 2014

qqueue commented Dec 18, 2014

I think I'm still having this issue. Both brick and polymer seem to polyfil fine on vanilla firefox 34, but as soon as I set dom.webcomponents.enabled to true, both projects' web pages break badly, e.g.:

screenshot from 2014-12-17 22 20 27

Similar results on 36a2 and 37 nightly. Turning the flag back off makes the site work fine again, in all three firefox versions.

Contributor

sole commented Dec 18, 2014

Yes, this is still an issue. Web components in Firefox registers as "all ready" and so the polyfill that is currently used doesn't kick into action, and so things do not work :-(

qqueue commented Dec 20, 2014

That confirms my suspicions, thanks. Do you know which bug tracks a fully working dom.webcomponents.enabled? There's the metabug https://bugzilla.mozilla.org/show_bug.cgi?id=811542 , but I dunno if that's more general than getting the feature flag working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment