New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color.scss not found #43

Closed
KoenLav opened this Issue May 28, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@KoenLav

KoenLav commented May 28, 2018

After updating to Meteor 1.7 (also in RC stage) I received this error, on Windows 10 x64:

/packages/mozfet_autoform-materialize/style.scss:
Scss compiler error:
File to import: {}/node_modules/materialize-css/sass/components/color.scss not found in file:

@KoenLav KoenLav referenced this issue May 28, 2018

Merged

Release 1.7 #9826

@mozfet

This comment has been minimized.

Owner

mozfet commented May 29, 2018

I've not yet tested the package with Meteor 1.7. Can you confirm that that Materialize CSS NPM package is installed in the app project and the path exists?

@KoenLav

This comment has been minimized.

KoenLav commented May 29, 2018

This is definitely the case.

@mozfet

This comment has been minimized.

Owner

mozfet commented May 29, 2018

Ok, I read the Meteor Release 1.7 thread... not sure how I can make it work in the package if the framework drops support for SCSS imports from node packages, I cannot believe that is intentional and agree with your statement that packages need this functionality...

I'm not sure what/why mlink is/needed, but creating symlinks in the imports folder to importing node packages work seem counterintuitive the meteor no-config approach.

That being said, it is working on 1.6.1.1 (on OSX) which is the latest stable release - if it breaks on the official released 1.7 it will be a setback and the only workaround I can think of is that scss will have to be manually installed in the app or some kind of symlink setup instructions needed to get the package to work... :(

I guess I will wait and see what happens when 1.7 is officially released. Unless someone else has any ideas.

@mozfet mozfet added the question label May 29, 2018

benjamn added a commit to meteor/meteor that referenced this issue May 29, 2018

Revert "Stop scanning node_modules directories in PackageSource#_find…
…Sources. (#9825)"

This reverts commit c5302bb.

Based on conversation with @KoenLav, it seems this optimization was more
of a breaking change than anticipated, and the workaround of creating a
symbolic link to induce compilation is not just annoying on Windows but
also does not satisfy the goal of being able to import from node_modules
(as before) rather than importing via the symbolic link.

We will need to revisit this pitfall in Meteor 1.7.1, but it's important
to unbreak it ASAP in Meteor 1.7.0.1 (since 1.7 is unfortunately final).

#9826 (comment)
mozfet/meteor-autoform-materialize#43

For apps that are accidentally compiling too many LESS or SCSS files, the
recommended workaround (for now) is to add the offending directories
and/or files to a .meteorignore file.
@KoenLav

This comment has been minimized.

KoenLav commented May 31, 2018

Meteor has resolved this issue, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment