Save memory on Global search API

pascalchevrel · pascalchevrel · commit c229d22da6c2 · 2016-01-11T16:25:41.000+01:00
By unsetting the $target_strings and $source_strings, we save 9MB per request, which is probably a good thing for performances of the API (for Pontoon).

That's an easy win on existing code.
diff --git a/app/models/api/translation_memory.php b/app/models/api/translation_memory.php
@@ -41,6 +41,7 @@
 
     $source_strings_merged = array_merge($source_strings, $source_strings_merged);
     $target_strings_merged = array_merge($target_strings, $target_strings_merged);
+    unset($source_strings, $target_strings);
 }
 
 return $json = ShowResults::getTranslationMemoryResults(

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@`
`41`	`41`
`42`	`42`	`$source_strings_merged = array_merge($source_strings, $source_strings_merged);`
`43`	`43`	`$target_strings_merged = array_merge($target_strings, $target_strings_merged);`
	`44`	`+ unset($source_strings, $target_strings);`
`44`	`45`	`}`
`45`	`46`
`46`	`47`	`return $json = ShowResults::getTranslationMemoryResults(`