Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison view should allow comparing strings across any repositories #320

Open
julen opened this issue Jul 10, 2014 · 9 comments
Open

Comparison view should allow comparing strings across any repositories #320

julen opened this issue Jul 10, 2014 · 9 comments
Assignees

Comments

@julen
Copy link

@julen julen commented Jul 10, 2014

The comparison view currently only allows comparing strings across grouped repositories, i.e. Gaia on the one hand (gaia-l10n, gaia-vxy), and the rest on the other hand (central,aurora, beta, release).

Since some strings that have already been localized in the products are being reused in Gaia (I can think of network-related strings, This address is restricted for instance), it'd be great being able to compare strings across any repositories, so I could see how a string has been localized in aurora and gaia-vxy repositories.

@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Jul 10, 2014

Would a checkbox on the main search view for strings to search on all repositories at once work for you?

@julen
Copy link
Author

@julen julen commented Jul 10, 2014

I don't know where the that checkbox would be displayed and I'm not sure I fully understand what you mean. As a user I'm fine with anything that allows me to have a cross-repo view of strings.

@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Jul 10, 2014

If you look at the main view, the search is per repository, my idea would be to either have a 'all repositories' option in the select box or a checkbox at the side of the select box with this same purpose.

@flodolo
Copy link
Contributor

@flodolo flodolo commented Jul 10, 2014

Julen is asking for "comparison view" involving all repositories, not a search.
While the second is definitely possible, not sure about the first: we compare translations for the same key (string id), not translations.

@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Jul 10, 2014

I understood his question, that's why I am proposing an alternative because we can't compare keys between Gaia and Desktop. I think my suggestion solves his use case but he should confirm.

@julen
Copy link
Author

@julen julen commented Jul 10, 2014

If you create a hash map of source strings, the comparison view should be possible and it wouldn't be expensive to query.

But an All repositories search would work fine I believe. Ideally users should be able to selectively filter the repositories displayed in the results.

@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Jul 10, 2014

I think I would tend towards an 'all repositories' option because Rimas asked for it last month so it may solve more use cases. Filtering per repository as we do now per folder is also probably feasible, we should make sure we don't turn the UI into Mozilla Suite prefs panel though :)

@pascalchevrel pascalchevrel self-assigned this Oct 21, 2015
@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Oct 21, 2015

I am working on the "all repositories" search option.

@julen
Copy link
Author

@julen julen commented Oct 21, 2015

Thank you @pascalchevrel, much appreciated!

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 26, 2015
* New search class with a fluent interface
* Removed "wildcard" search option from main view
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 30, 2015
* New search class with a fluent interface
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 30, 2015
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 30, 2015
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 30, 2015
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 30, 2015
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 30, 2015
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 31, 2015
pascalchevrel added a commit that referenced this issue Dec 31, 2015
Issues #320: move all our regex logic into a unit tested class
TheoChevalier added a commit to TheoChevalier/transvision that referenced this issue Jan 4, 2016
* New search class with a fluent interface
* Removed "wildcard" search option from main view
TheoChevalier added a commit to TheoChevalier/transvision that referenced this issue Jan 6, 2016
* New search class with a fluent interface
* Removed "wildcard" search option from main view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.