New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaia Master for Danish extraction fails, leading to corrupt php cache file #447

Closed
pascalchevrel opened this Issue Apr 9, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@pascalchevrel
Member

pascalchevrel commented Apr 9, 2015

file generated:

<?php
$tmx = [

@pascalchevrel pascalchevrel added the bug label Apr 9, 2015

@pascalchevrel pascalchevrel self-assigned this Apr 9, 2015

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Apr 9, 2015

Member

Found the bug, it is not in our code, there is a "Windows1252" encoded properties file in the Gaia repository for Gaia that makes the Silme library stop the python script, so this needs to be fixed by the localizer.

I am going to fix tmxmaker.py to print an error message we will see in the cron job message and to close the php file when it happens

Member

pascalchevrel commented Apr 9, 2015

Found the bug, it is not in our code, there is a "Windows1252" encoded properties file in the Gaia repository for Gaia that makes the Silme library stop the python script, so this needs to be fixed by the localizer.

I am going to fix tmxmaker.py to print an error message we will see in the cron job message and to close the php file when it happens

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Apr 9, 2015

Contributor

That's weird, it seems to work for me locally.

-rw-r--r--  1 flodolo flodolo 470653 Apr  8 14:04 cache_da.php
-rw-r--r--  1 flodolo flodolo 461834 Apr  8 14:04 cache_en-US.php
-rw-r--r--  1 flodolo flodolo 933547 Jun 10  2014 memoire_en-US_da.tmx
Contributor

flodolo commented Apr 9, 2015

That's weird, it seems to work for me locally.

-rw-r--r--  1 flodolo flodolo 470653 Apr  8 14:04 cache_da.php
-rw-r--r--  1 flodolo flodolo 461834 Apr  8 14:04 cache_en-US.php
-rw-r--r--  1 flodolo flodolo 933547 Jun 10  2014 memoire_en-US_da.tmx

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Apr 9, 2015

Issue #447: Fix Danish extraction of data
- If Silme can't extract data from a repo, print an error message and close the php file created
- Remove dead code in tmxmaker.py
@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Apr 9, 2015

Member

Jorgen fixed the encoding issue last night so you probably have a fresher hg checkout:
https://hg.mozilla.org/gaia-l10n/da/rev/3f8842dd4407

I had the same bug locally with hg repos a couple days old

Member

pascalchevrel commented Apr 9, 2015

Jorgen fixed the encoding issue last night so you probably have a fresher hg checkout:
https://hg.mozilla.org/gaia-l10n/da/rev/3f8842dd4407

I had the same bug locally with hg repos a couple days old

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Apr 9, 2015

Contributor

OK, makes sense then (I did update 'da' before trying).

Contributor

flodolo commented Apr 9, 2015

OK, makes sense then (I did update 'da' before trying).

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Apr 9, 2015

Issue #447: Fix Danish extraction of data
- If Silme can't extract data from a folder:
  1. print an error message
  2. skip the folder
- Remove dead code in tmxmaker.py

pascalchevrel added a commit that referenced this issue Apr 9, 2015

Merge pull request #448 from pascalchevrel/issue-447
Issue #447: Fix Danish extraction of data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment