New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'wildcard' search option #549

Closed
pascalchevrel opened this Issue Dec 23, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@pascalchevrel
Copy link
Member

pascalchevrel commented Dec 23, 2015

The reasons are:

  • I don't understand myself how it is supposed to work and I think we actually broke it a long time ago and nobody noticed, so basically noibody uses it ;)
  • I am rewriting the whole search process with a class that also takes care of defining the regex and I would like to remove the implementation of that feature since it just reproduces the current broken behaviour
  • it would simplify our option choices with the ones that are really useful

Thoughts?

@pascalchevrel

This comment has been minimized.

Copy link
Member Author

pascalchevrel commented Dec 23, 2015

@flodolo @TheoChevalier @SkySymbol pinging active people :)

@pascalchevrel

This comment has been minimized.

Copy link
Member Author

pascalchevrel commented Dec 23, 2015

btw, I would also rename "Whole word" as "Contiguous words", we use the regex wording for the feature and I think nobody gets what it actually means

@flodolo

This comment has been minimized.

Copy link
Contributor

flodolo commented Dec 23, 2015

Absolutely 'yes' for wildcard, I'm not convinced about 'Whole word': I use it exactly to search for the entire word, e.g. cookie (i.e. I don't want 'cookies').

'Contiguous words" sounds like a search for "open window" should only return a search with strings that contain "open window", in that order.

@TheoChevalier

This comment has been minimized.

Copy link
Member

TheoChevalier commented Dec 23, 2015

Agreed for wildcard, never used it nor understood it.
Regarding Whole word, I’m fine to change it if we find something clearer, but maybe we could also use a tooltip to give more detail? Like "Only keep results containg those words"

@pascalchevrel

This comment has been minimized.

Copy link
Member Author

pascalchevrel commented Dec 23, 2015

ok, so let's scrap wildcard and brainstorm on the right wording for "whole word" as we have several use cases, like the one by flod with a single word and the one I have when I want to return strings that have contiguous words seen as a single string, ex:
https://transvision.mozfr.org/?recherche=Private+Browsing&repo=release&sourcelocale=en-US&locale=fr&search_type=strings&whole_word=whole_word

I like the tooltip ideas that we could add to all options actually, I would put that in a separate issues as a good first bug.

@ghost

This comment has been minimized.

Copy link

ghost commented Dec 23, 2015

+1 for the wildcard search option, but I disagree for renaming the whole word feature, as it seems to be the correct appellation. See for example this post on Stackoverflow.

@pascalchevrel

This comment has been minimized.

Copy link
Member Author

pascalchevrel commented Dec 24, 2015

the problem with the naming is that the people that use Transvision don't know what a regex is, so the question is not what the right naming is technically, but what the right naming is to make the feature understandable by end-users.

@pascalchevrel

This comment has been minimized.

Copy link
Member Author

pascalchevrel commented Dec 26, 2015

I removed the wildcard option in the branch I am working on for Issues #320

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 30, 2015

flodolo added a commit that referenced this issue Dec 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment