Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search suggestions as your type in main search from our own API #551

Closed
pascalchevrel opened this issue Dec 25, 2015 · 0 comments
Closed

Add search suggestions as your type in main search from our own API #551

pascalchevrel opened this issue Dec 25, 2015 · 0 comments
Assignees
@pascalchevrel

Comments

@pascalchevrel
Copy link
Member

I have a patch that allows using our own Transvision API to autocomplete suggestions as you type in the search bar.
@pascalchevrel pascalchevrel self-assigned this Dec 25, 2015
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 25, 2015
@pascalchevrel
Issue mozfr#551: Search suggestion autocomplete
0c6b769
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Dec 25, 2015
@pascalchevrel
Issue mozfr#551: Search suggestion autocomplete
ce33971
pascalchevrel added a commit that referenced this issue Dec 25, 2015
@pascalchevrel
Merge pull request #552 from pascalchevrel/autocomplete
5915ad2 
Issue #551: Search suggestion autocomplete
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Jan 1, 2016
@pascalchevrel
Issue mozfr#551: fix autocomplete in Chrome
959fbca 
Chrome does not take the 'params' option into account to update the query with this error message:

Uncaught TypeError: Cannot assign to read only property 'query' of max_results=10b.getSuggestions @ jquery.autocomplete.min.js?v=unknown.dev:8b.onValueChange @ jquery.autocomplete.min.js?v=unknown.dev:8b.onKeyUp @ jquery.autocomplete.min.js?v=unknown.dev:8(anonymous function) @ jquery.autocomplete.min.js?v=unknown.dev:8m.event.dispatch @ jquery.min.js?v=unknown.dev:4r.handle @ jquery.min.js?v=unknown.dev:4

Appending the max_results paramater directly to the return value of serviceurl works in both Firefox and Chrome
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Jan 1, 2016
@pascalchevrel
Issue mozfr#551: fix autocomplete in Chrome
a21cb89 
Chrome does not take the 'params' option into account to update the query with this error message:

Uncaught TypeError: Cannot assign to read only property 'query' of max_results=10b.getSuggestions @ jquery.autocomplete.min.js?v=unknown.dev:8b.onValueChange @ jquery.autocomplete.min.js?v=unknown.dev:8b.onKeyUp @ jquery.autocomplete.min.js?v=unknown.dev:8(anonymous function) @ jquery.autocomplete.min.js?v=unknown.dev:8m.event.dispatch @ jquery.min.js?v=unknown.dev:4r.handle @ jquery.min.js?v=unknown.dev:4

Stack Overflow solution:
http://stackoverflow.com/questions/26602063/additional-params-in-jquery-autocomplete
pascalchevrel added a commit that referenced this issue Jan 1, 2016
@pascalchevrel
Merge pull request #567 from pascalchevrel/chrome_autocomplete_bug
5620048 
Issue #551: fix autocomplete in Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalchevrel pascalchevrel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pascalchevrel