Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New suggestion API doesn't work without max_results parameter #576

Closed
pascalchevrel opened this issue Jan 4, 2016 · 0 comments
Closed

New suggestion API doesn't work without max_results parameter #576

pascalchevrel opened this issue Jan 4, 2016 · 0 comments
Assignees
@MatonAnthony
Labels
bug easypick Hackathon

Comments

@pascalchevrel
Copy link
Member

The new suggestion API should return results if the max_results option is not set, currently it returns an empty array, it probably just needs to get a default value for max_results.
@MatonAnthony MatonAnthony self-assigned this Feb 12, 2016
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016
@MatonAnthony
Fix issue mozfr#576
4560143
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016
@MatonAnthony
Fix issue mozfr#576
0608449
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016
@MatonAnthony
Fix issue mozfr#576
2c8dbbe
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016
@MatonAnthony
Fix issue mozfr#576
2919fdb
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016
@MatonAnthony
Fix issue mozfr#576
e8b6264
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016
@MatonAnthony
Fix issue mozfr#576
c44c13e
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 13, 2016
@MatonAnthony
Fix issue mozfr#576
fbd64ba
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 13, 2016
@MatonAnthony
Fix issue mozfr#576
885f4ea
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 14, 2016
@MatonAnthony
Fix issue mozfr#576
e3a385f 
Correction of a typo at Flod request
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 14, 2016
@MatonAnthony
Fix issue mozfr#576
22933f4 
Correction of a typo at Flod request

Using php-cs-fixer fix .
MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 14, 2016
@MatonAnthony
Fix issue mozfr#576
abe3296 
Correction of a typo at Flod request

Using php-cs-fixer fix .

Fix php-cs-fixer craziness
pascalchevrel added a commit that referenced this issue Feb 23, 2016
@pascalchevrel
Merge pull request #619 from MatonAnthony/patch-issue-576
d2f3d87 
Fix issue #576 Suggestion API not working without max_results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatonAnthony MatonAnthony

Labels
bug easypick Hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pascalchevrel @MatonAnthony