New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New suggestion API doesn't work without max_results parameter #576

Closed
pascalchevrel opened this Issue Jan 4, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@pascalchevrel
Member

pascalchevrel commented Jan 4, 2016

The new suggestion API should return results if the max_results option is not set, currently it returns an empty array, it probably just needs to get a default value for max_results.

@MatonAnthony MatonAnthony self-assigned this Feb 12, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 12, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 13, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 13, 2016

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 14, 2016

Fix issue #576
Correction of a typo at Flod request

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 14, 2016

Fix issue #576
Correction of a typo at Flod request

Using php-cs-fixer fix .

MatonAnthony added a commit to MatonAnthony/transvision that referenced this issue Feb 14, 2016

Fix issue #576
Correction of a typo at Flod request

Using php-cs-fixer fix .

Fix php-cs-fixer craziness

pascalchevrel added a commit that referenced this issue Feb 23, 2016

Merge pull request #619 from MatonAnthony/patch-issue-576
Fix issue #576 Suggestion API not working without max_results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment