Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In debug mode, send perf metrics in custom http header #593

Closed
pascalchevrel opened this issue Jan 19, 2016 · 2 comments
Closed

In debug mode, send perf metrics in custom http header #593

pascalchevrel opened this issue Jan 19, 2016 · 2 comments
Assignees

Comments

@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Jan 19, 2016

Currently we can log our metrics in debug mode in the console (or the apache logs if one does not use the php dev server).

I think it would be convenient to also send this data in a custom http header when in debug mode, this way we can see on the beta server or our VPSs wat the perf of a page is without having to ssh and look at the logs. HTTP headers are also more convenient than outputing directly this infoirmation in the view because the views we need most performance from are the json api and we can't ourput data there.

I quickly checked and it's easy to do, see in the screenshot below the result in firebug, I called the .header Transvision-perf.

entetes

I have something tthat works now but maybe I should let it to a new contributor? Do you like the idea?

@pascalchevrel pascalchevrel changed the title In debug mode, send perf metrics in custom http In debug mode, send perf metrics in custom http header Jan 19, 2016
@pascalchevrel
Copy link
Member Author

@pascalchevrel pascalchevrel commented Jan 28, 2016

We are having an l10n hackathon mid-February and we will have a table with at least 4 people working on Transvision. I am putting that bug in the backlog of bugs to fix for the event.

Thegennok added a commit to Thegennok/transvision that referenced this issue Feb 14, 2016
@flodolo
Copy link
Contributor

@flodolo flodolo commented Feb 14, 2016

(side note: the header is visible also in Vanilla devtools: network tab, click on the 200 response, right column)

Thegennok added a commit to Thegennok/transvision that referenced this issue Feb 14, 2016
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Feb 18, 2016
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Feb 22, 2016
- New header: Transvision-perf
- Does not depend on DEBUG of PERF_CHECK to be checked because we don't impact the server logs with http headers and it allows getting perf metrics on production easily
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Feb 22, 2016
- New header: Transvision-perf
- Does not depend on DEBUG of PERF_CHECK to be checked because we don't impact the server logs with http headers and it allows getting perf metrics on production easily
pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Feb 22, 2016
- New header: Transvision-perf
- Does not depend on DEBUG of PERF_CHECK to be checked because we don't impact the server logs with http headers and it allows getting perf metrics on production easily
pascalchevrel added a commit that referenced this issue Feb 22, 2016
Issue #593: add http headers with perf metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.