-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate quality values in API #597
Comments
The reason we don't truncate is to be fully compatible with Amagama that Pontoon also uses: We can truncate but we need to check with matjaz first that it doesn't impact his code |
To clarify: truncate as in exposing less decimals, not truncating to integers. Given that quality could be 100 (or 40 in the example above from Transvision), I wouldn't expect breakages. |
no problem with that, but let's check with matjaz first, I don't want anything to break on Pontoon :) |
@mathjazz Do you see any issue with reducing the number of decimals for quality in our API response? |
r+ Pontoon uses |
Taking this one, I think 2 decimals is a good number |
…uality_value_to_2_decimals Issue #597: round quality parameter in 'tm' API to 2 decimals
I don't think there's value in exposing so many decimals, e.g. source
quality: 42.857142857143
https://transvision.mozfr.org/api/v1/tm/aurora/it/it/fin/?max_results=10
The text was updated successfully, but these errors were encountered: