Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
I don't think there's value in exposing so many decimals, e.g. source quality: 42.857142857143
The text was updated successfully, but these errors were encountered:
The reason we don't truncate is to be fully compatible with Amagama that Pontoon also uses:
We can truncate but we need to check with matjaz first that it doesn't impact his code
Sorry, something went wrong.
To clarify: truncate as in exposing less decimals, not truncating to integers.
Given that quality could be 100 (or 40 in the example above from Transvision), I wouldn't expect breakages.
no problem with that, but let's check with matjaz first, I don't want anything to break on Pontoon :)
@mathjazz Do you see any issue with reducing the number of decimals for quality in our API response?
Pontoon uses Math.round(quality), so it displays quality wihout decimals. Thanks for asking!
Taking this one, I think 2 decimals is a good number
Issue mozfr#597: round quality parameter in 'tm' API to 2 decimals
Merge pull request #598 from pascalchevrel/issue597_truncate_tm_api_q…
Issue #597: round quality parameter in 'tm' API to 2 decimals
No branches or pull requests