Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributing.md #608

Closed
pascalchevrel opened this issue Feb 5, 2016 · 2 comments
Closed

Update Contributing.md #608

pascalchevrel opened this issue Feb 5, 2016 · 2 comments

Comments

@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Feb 5, 2016

  • Minimum PHP is now 5.6
  • Launching tests is now start.sh -tests
  • Setting the remote should use the name "upstream" as it is the general convention for Github forking
  • More?
@ghost
Copy link

@ghost ghost commented Feb 14, 2016

I would suggest to link to Francesco's git tuto

@ghost
Copy link

@ghost ghost commented Feb 14, 2016

Contribution tips should be moved from README.md to CONTRIBUTING.md. And we should link to CONTRIBUTING.md inside the README In the Contribution tips

@pascalchevrel pascalchevrel assigned ghost Feb 22, 2016
pascalchevrel added a commit that referenced this issue Mar 1, 2016
Fix #608 update CONTRIBUTING.md and the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@pascalchevrel and others
You can’t perform that action at this time.