New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributing.md #608

Closed
pascalchevrel opened this Issue Feb 5, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@pascalchevrel
Member

pascalchevrel commented Feb 5, 2016

  • Minimum PHP is now 5.6
  • Launching tests is now start.sh -tests
  • Setting the remote should use the name "upstream" as it is the general convention for Github forking
  • More?
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 14, 2016

I would suggest to link to Francesco's git tuto

ghost commented Feb 14, 2016

I would suggest to link to Francesco's git tuto

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 14, 2016

Contribution tips should be moved from README.md to CONTRIBUTING.md. And we should link to CONTRIBUTING.md inside the README In the Contribution tips

ghost commented Feb 14, 2016

Contribution tips should be moved from README.md to CONTRIBUTING.md. And we should link to CONTRIBUTING.md inside the README In the Contribution tips

@pascalchevrel pascalchevrel assigned ghost Feb 22, 2016

pascalchevrel added a commit that referenced this issue Mar 1, 2016

Merge pull request #646 from SkySymbol/update_credit
Fix #608 update CONTRIBUTING.md and the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment