Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing.md #608

Closed
pascalchevrel opened this issue Feb 5, 2016 · 2 comments
Closed

Update Contributing.md #608

pascalchevrel opened this issue Feb 5, 2016 · 2 comments
Labels
easypick Hackathon

Comments

@pascalchevrel
Copy link
Member

  • Minimum PHP is now 5.6
  • Launching tests is now start.sh -tests
  • Setting the remote should use the name "upstream" as it is the general convention for Github forking
  • More?
@ghost
Copy link

ghost commented Feb 14, 2016

I would suggest to link to Francesco's git tuto

@ghost
Copy link

ghost commented Feb 14, 2016

Contribution tips should be moved from README.md to CONTRIBUTING.md. And we should link to CONTRIBUTING.md inside the README In the Contribution tips

@pascalchevrel pascalchevrel assigned ghost Feb 22, 2016
pascalchevrel added a commit that referenced this issue Mar 1, 2016
@pascalchevrel
Merge pull request #646 from SkySymbol/update_credit
6aebf57 
Fix #608 update CONTRIBUTING.md and the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easypick Hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pascalchevrel