multi word searches only searched as exact string, not multiple strings #644

Closed
Archaeopteryx opened this Issue Feb 23, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@Archaeopteryx

Searches for multiple words only work if they are one exact match. E.g.
The search for 'restart disabled' returns nothing but there are several strings which contain these words.

If I remember correct, this worked in the past (and yielded many uninteresting matches if one had to search for common words).

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Feb 23, 2016

Member

git bisect gives me this:
87d3405 is the first bad commit
commit 87d3405
Author: Pascal Chevrel pascal.chevrel@free.fr
Date: Sun Nov 15 19:00:48 2015 +0100

Issues #320: move all our regex logic into a unit tested class
:040000 040000 ecfb0046a95aa33e7791649be2ed55428d390169 31132c9142c3a2ec20238e376b6e18735ef17f2e M  app
:040000 040000 8a401d63d718c7e00d0ef0b880ea133c065cf5a6 786a4f0f94f2527c83181c4a9cfca6a507f5996e M  tests
Member

pascalchevrel commented Feb 23, 2016

git bisect gives me this:
87d3405 is the first bad commit
commit 87d3405
Author: Pascal Chevrel pascal.chevrel@free.fr
Date: Sun Nov 15 19:00:48 2015 +0100

Issues #320: move all our regex logic into a unit tested class
:040000 040000 ecfb0046a95aa33e7791649be2ed55428d390169 31132c9142c3a2ec20238e376b6e18735ef17f2e M  app
:040000 040000 8a401d63d718c7e00d0ef0b880ea133c065cf5a6 786a4f0f94f2527c83181c4a9cfca6a507f5996e M  tests

@pascalchevrel pascalchevrel self-assigned this Feb 23, 2016

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Feb 23, 2016

pascalchevrel added a commit that referenced this issue Feb 23, 2016

Merge pull request #645 from pascalchevrel/issue644_fix_multiword_str…
…ing_search

Issue #644: fix multiword search + fix a call to getRegex()
@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Feb 23, 2016

Member

This is fixed on master and the beta sites yields results:
https://transvision-beta.mozfr.org/?recherche=restart+disabled&repo=aurora&sourcelocale=en-US&locale=de&search_type=strings

Note though that the beta site doesn't get its data updated automatically as production, so you will need to wait for the next release to get that fix on production.

Thanks for reporting the regression.

Member

pascalchevrel commented Feb 23, 2016

This is fixed on master and the beta sites yields results:
https://transvision-beta.mozfr.org/?recherche=restart+disabled&repo=aurora&sourcelocale=en-US&locale=de&search_type=strings

Note though that the beta site doesn't get its data updated automatically as production, so you will need to wait for the next release to get that fix on production.

Thanks for reporting the regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment