New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some direct links to strings are leading to blank pages #655

Closed
TheoChevalier opened this Issue Mar 2, 2016 · 4 comments

Comments

Projects
None yet
3 participants

@TheoChevalier TheoChevalier added the bug label Mar 2, 2016

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Mar 2, 2016

Contributor

Interesting, no error on log or on video locally either 😮

Contributor

flodolo commented Mar 2, 2016

Interesting, no error on log or on video locally either 😮

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Mar 2, 2016

Member

It seem to only happen when the entity ends with a number:
mail/chrome/messenger/mime.properties:1008

Member

pascalchevrel commented Mar 2, 2016

It seem to only happen when the entity ends with a number:
mail/chrome/messenger/mime.properties:1008

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Mar 2, 2016

Contributor

I could be wrong but I think we fail around here (very early). But in parse_url?

Contributor

flodolo commented Mar 2, 2016

I could be wrong but I think we fail around here (very early). But in parse_url?

@pascalchevrel pascalchevrel self-assigned this Mar 2, 2016

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Mar 2, 2016

Member

yes, parse_url returns false when the url is not parsable, which happens when we end it with :1008, maybe it thinks that it is a port. I have a local patch that seems to work, at least with the dev server, will investigate more tomorrow

Member

pascalchevrel commented Mar 2, 2016

yes, parse_url returns false when the url is not parsable, which happens when we end it with :1008, maybe it thinks that it is a port. I have a local patch that seems to work, at least with the dev server, will investigate more tomorrow

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Mar 2, 2016

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Mar 2, 2016

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Mar 2, 2016

pascalchevrel added a commit to pascalchevrel/transvision that referenced this issue Mar 2, 2016

flodolo added a commit that referenced this issue Mar 3, 2016

Merge pull request #656 from pascalchevrel/issue655_fix_url_parsing_r…
…outer_script

Issue #655: escape semi-colon in query string to make the url parsable

@flodolo flodolo closed this Mar 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment