[consistency] Seemingly similar strings displayed as different #661

Closed
ghost opened this Issue Mar 3, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Mar 3, 2016

happening sometimes, there is no visible diff between exposed strings.

diff_unclear 3
diff_unclear 2
diff_unclear

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Mar 3, 2016

Member

we should study the differences, it could be errors or it could also be trailing spaces or unicode non-breaking spaces. I am going to have a look

Member

pascalchevrel commented Mar 3, 2016

we should study the differences, it could be errors or it could also be trailing spaces or unicode non-breaking spaces. I am going to have a look

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Mar 3, 2016

Contributor

It's a know issue in need of improvement. The strings are similar but different, one of them has one or more trailing whitespaces (you notice them by double/triple clicking on the string to select it).

The idea of keeping (and not trimming) trailing spaces is wanted, but we should highlight them somehow when displaying the string.

Contributor

flodolo commented Mar 3, 2016

It's a know issue in need of improvement. The strings are similar but different, one of them has one or more trailing whitespaces (you notice them by double/triple clicking on the string to select it).

The idea of keeping (and not trimming) trailing spaces is wanted, but we should highlight them somehow when displaying the string.

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Mar 3, 2016

Contributor

The alternative is to trim whitespaces directly when storing the translation, but I'm afraid we could loose some useful data: why is there a whitespace? Is it needed? It would be useful in general to be able to highlight whitespaces like we do for non breaking spaces in some views.

Contributor

flodolo commented Mar 3, 2016

The alternative is to trim whitespaces directly when storing the translation, but I'm afraid we could loose some useful data: why is there a whitespace? Is it needed? It would be useful in general to be able to highlight whitespaces like we do for non breaking spaces in some views.

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Mar 3, 2016

Member

I can have a look at highlighting whitespaces tomorrow (we actually already do
on the main view for non breaking spaces in French).

Member

pascalchevrel commented Mar 3, 2016

I can have a look at highlighting whitespaces tomorrow (we actually already do
on the main view for non breaking spaces in French).

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Mar 4, 2016

Member

capture d ecran 2016-03-04 11 08 37

Here is a screenshot of a patch to expose white space, unicode non breaking spaces and real ellipsis.

Member

pascalchevrel commented Mar 4, 2016

capture d ecran 2016-03-04 11 08 37

Here is a screenshot of a patch to expose white space, unicode non breaking spaces and real ellipsis.

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Mar 4, 2016

Contributor

Can you show one with a trailing space (e.g. one of the string in goofy's report)? The light gray used for non-breaking spaces might be too subtle for that.

Contributor

flodolo commented Mar 4, 2016

Can you show one with a trailing space (e.g. one of the string in goofy's report)? The light gray used for non-breaking spaces might be too subtle for that.

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
Member

pascalchevrel commented Mar 4, 2016

capture d ecran 2016-03-04 18 31 40

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Mar 4, 2016

Member

all exemples by Googy had a trailing non breaking space, I haven't found one with a real space

Member

pascalchevrel commented Mar 4, 2016

all exemples by Googy had a trailing non breaking space, I haven't found one with a real space

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Mar 4, 2016

Contributor

I think it looks good.

Contributor

flodolo commented Mar 4, 2016

I think it looks good.

@flodolo flodolo closed this Mar 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment