Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unlocalized strings] Sanitize English words before displaying, fix first row style #670

Closed
flodolo opened this issue Mar 5, 2016 · 1 comment · Fixed by #675
Closed

[unlocalized strings] Sanitize English words before displaying, fix first row style #670

flodolo opened this issue Mar 5, 2016 · 1 comment · Fixed by #675
Assignees
@flodolo

Comments

@flodolo
Copy link
Collaborator

flodolo commented Mar 5, 2016

Realized on my demo server where the packages weren't installed yet, HTML code was displayed as part of the English string (and iframe was displayed).

We shouldn't also displaying the first row as an header (I had the same issue with the consistency table, so there's a rule do display the right color).
@flodolo
Copy link
Collaborator Author

flodolo commented Mar 6, 2016

Maybe we should strip tags from the string before splitting it up into words

@flodolo flodolo self-assigned this Mar 11, 2016
@flodolo flodolo mentioned this issue Mar 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flodolo flodolo

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@flodolo